Merge pull request #15079 from rabbitmq/mergify/bp/v4.1.x/pr-15078

gmake run-broker, gmake start-cluster: use a very short plugin list by default (backport #15072) (backport #15078)

Author: michaelklishin

CONTRIBUTING.md

@@ -84,8 +84,8 @@ with-env {'RABBITMQ_METADATA_STORE': 'khepri'} { gmake ct-quorum_queue }
 
 ``` shell
 # Run from repository root.
-# Starts a node with the management plugin enabled
-gmake run-broker RABBITMQ_PLUGINS=rabbitmq_management
+# Starts a node with management and two stream plugins enabled
+gmake run-broker ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
 ```
 
 The nodes will be started in the background. They will use `rabbit@{hostname}` for its name, so CLI will be able to contact
@@ -100,8 +100,8 @@ it without an explicit `-n` (`--node`) argument:
 
 ``` shell
 # Run from repository root.
-# Starts a three node cluster with the management plugin enabled
-gmake start-cluster NODES=3 RABBITMQ_PLUGINS=rabbitmq_management
+# Starts a three node cluster with management and two stream plugins enabled
+gmake start-cluster NODES=3 ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
 ```
 
 The node will use `rabbit-{n}@{hostname}` for names, so CLI must
@@ -142,8 +142,8 @@ gmake stop-cluster NODES=3
 When working on management UI code, besides starting the node with
 
 ``` shell
-# starts a node with the management plugin enabled
-gmake run-broker RABBITMQ_PLUGINS=rabbitmq_management
+# starts a node with management and two stream plugins enabled
+gmake run-broker ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
 ```
 
 (or any other set of plugins), it is highly recommended to use [BrowserSync](https://browsersync.io/#install)

Makefile

@@ -66,16 +66,19 @@ ifdef COMMUNITY_PLUGINS
 DEPS += $(RABBITMQ_COMMUNITY)
 endif
 
+# Plugins to enable for `gmake run-broker`, `gmake start-cluster`, etc.
+# To override:
+#     gmake run-broker ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream"
+#     gmake start-cluster NODES=3 ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
+ENABLED_PLUGINS ?= rabbitmq_management
+RABBITMQ_ENABLED_PLUGINS ?= $(call comma_list,$(ENABLED_PLUGINS))
+# This is necessary for the recursively called targets
+# used by `gmake start-cluster`.
+export RABBITMQ_ENABLED_PLUGINS
+
 include erlang.mk
 include mk/github-actions.mk
 
-# If PLUGINS was set when we use run-broker we want to
-# fill in the enabled plugins list. PLUGINS is a more
-# natural space-separated list.
-ifdef PLUGINS
-RABBITMQ_ENABLED_PLUGINS ?= $(call comma_list,$(PLUGINS))
-endif
-
 # --------------------------------------------------------------------
 # Distribution - common variables and generic functions.
 # --------------------------------------------------------------------

deps/rabbitmq_auth_backend_internal_loopback/CONTRIBUTING.md

@@ -105,8 +105,8 @@ will run the older version.
 
 ``` shell
 # Run from repository root.
-# Starts a node with the management plugin enabled
-gmake run-broker RABBITMQ_PLUGINS=rabbitmq_management
+# Starts a node with management and two stream plugins enabled
+gmake run-broker ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
 ```
 
 The nodes will be started in the background. They will use `rabbit@{hostname}` for its name, so CLI will be able to contact
@@ -121,8 +121,8 @@ it without an explicit `-n` (`--node`) argument:
 
 ``` shell
 # Run from repository root.
-# Starts a three node cluster with the management plugin enabled
-gmake start-cluster NODES=3 RABBITMQ_PLUGINS=rabbitmq_management
+# Starts a three node cluster with management and two stream plugins enabled
+gmake start-cluster NODES=3 ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
 ```
 
 The node will use `rabbit-{n}@{hostname}` for names, so CLI must
@@ -163,8 +163,8 @@ gmake stop-cluster NODES=3
 When working on management UI code, besides starting the node with
 
 ``` shell
-# starts a node with the management plugin enabled
-gmake run-broker RABBITMQ_PLUGINS=rabbitmq_management
+# starts a node with management and two stream plugins enabled
+gmake run-broker ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
 ```
 
 (or any other set of plugins), it is highly recommended to use [BrowserSync](https://browsersync.io/#install)

deps/rabbitmq_cli/Makefile

@@ -122,7 +122,7 @@ $(LINKED_ESCRIPTS): $(ESCRIPT_FILE)
 tests:: escript test-deps
 	$(verbose) $(MAKE) -C ../../ install-cli
 	$(verbose) $(MAKE) -C ../../ start-background-broker \
-		PLUGINS="rabbitmq_federation rabbitmq_stomp rabbitmq_stream_management amqp_client" \
+		ENABLED_PLUGINS="rabbitmq_federation rabbitmq_stomp rabbitmq_stream_management amqp_client" \
 		$(if $(filter khepri,$(RABBITMQ_METADATA_STORE)),,RABBITMQ_FEATURE_FLAGS="-khepri_db"); \
 		rm -f logs; \
 		log_dir=$$(../../sbin/rabbitmqctl eval 'io:format("~s~n", [maps:get(log_base_dir,rabbit_prelaunch:get_context())]).'); \