Skip to content

Commit 11ceb3c

Browse files
committed
renaming, added tests
1 parent c02ff69 commit 11ceb3c

File tree

7 files changed

+87
-73
lines changed

7 files changed

+87
-73
lines changed

jbbp/src/main/java/com/igormaznitsa/jbbp/JBBPParser.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import com.igormaznitsa.jbbp.compiler.JBBPCompiledBlock;
2020
import com.igormaznitsa.jbbp.compiler.JBBPCompiler;
2121
import com.igormaznitsa.jbbp.compiler.JBBPNamedFieldInfo;
22-
import com.igormaznitsa.jbbp.compiler.conversion.JBBPToJava6Converter;
22+
import com.igormaznitsa.jbbp.compiler.conversion.JBBPToJavaConverter;
2323
import com.igormaznitsa.jbbp.compiler.tokenizer.JBBPFieldTypeParameterContainer;
2424
import com.igormaznitsa.jbbp.compiler.varlen.JBBPIntegerValueEvaluator;
2525
import com.igormaznitsa.jbbp.exceptions.JBBPParsingException;
@@ -712,8 +712,8 @@ public JBBPCompiledBlock getCompiledBlock() {
712712
* @param name name of result, depends on target, must not be null, for instance class name (example 'com.test.jbbp.Parser')
713713
* @return list of source items generated during operation, must not be null and must not be empty
714714
* @throws IllegalArgumentException if target is unsupported
715-
* @see JBBPToJava6Converter
716-
* @see JBBPToJava6Converter.Builder
715+
* @see JBBPToJavaConverter
716+
* @see JBBPToJavaConverter.Builder
717717
* @since 1.3.0
718718
*/
719719
public List<ResultSrcItem> convertToSrc(final TargetSources target, final String name) {
@@ -724,7 +724,7 @@ public List<ResultSrcItem> convertToSrc(final TargetSources target, final String
724724
metadata.setProperty("script", this.compiledBlock.getSource());
725725
metadata.setProperty("name", name);
726726
metadata.setProperty("target", target.name());
727-
metadata.setProperty("converter", JBBPToJava6Converter.class.getCanonicalName());
727+
metadata.setProperty("converter", JBBPToJavaConverter.class.getCanonicalName());
728728

729729
final int nameStart = name.lastIndexOf('.');
730730
final String packageName;
@@ -737,7 +737,7 @@ public List<ResultSrcItem> convertToSrc(final TargetSources target, final String
737737
className = name.substring(nameStart + 1);
738738
}
739739

740-
final String resultSources = JBBPToJava6Converter.makeBuilder(this).setMainClassPackage(packageName).setMainClassName(className).build().convert();
740+
final String resultSources = JBBPToJavaConverter.makeBuilder(this).setMainClassPackage(packageName).setMainClassName(className).build().convert();
741741
final Map<String, String> resultMap = Collections.singletonMap(name.replace('.', '/') + ".java", resultSources);
742742

743743
return Collections.singletonList(new ResultSrcItem() {

jbbp/src/main/java/com/igormaznitsa/jbbp/compiler/conversion/JBBPToJava6Converter.java renamed to jbbp/src/main/java/com/igormaznitsa/jbbp/compiler/conversion/JBBPToJavaConverter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
* @since 1.3.0
4848
*/
4949
@SuppressWarnings("SpellCheckingInspection")
50-
public final class JBBPToJava6Converter extends CompiledBlockVisitor {
50+
public final class JBBPToJavaConverter extends CompiledBlockVisitor {
5151

5252
private static final int FLAG_DETECTED_CUSTOM_FIELDS = 1;
5353
private static final int FLAG_DETECTED_EXTERNAL_FIELDS = 2;
@@ -179,7 +179,7 @@ public final class JBBPToJava6Converter extends CompiledBlockVisitor {
179179
*
180180
* @param builder a builder instance, must not be null
181181
*/
182-
private JBBPToJava6Converter(final Builder builder) {
182+
private JBBPToJavaConverter(final Builder builder) {
183183
super(builder.parserFlags, builder.srcParser.getCompiledBlock());
184184
this.builder = builder;
185185
}
@@ -201,7 +201,7 @@ public static Builder makeBuilder(final JBBPParser parser) {
201201
* @return generated class with needed parameters as text, must not be null.
202202
*/
203203
public String convert() {
204-
return ((JBBPToJava6Converter) this.visit()).getResult();
204+
return ((JBBPToJavaConverter) this.visit()).getResult();
205205
}
206206

207207
private void registerNamedField(final JBBPNamedFieldInfo fieldInfo, final FieldType fieldType) {
@@ -324,7 +324,7 @@ public void visitEnd() {
324324
final Struct rootStruct = this.structStack.get(0);
325325

326326
if (this.builder.genNewInstance) {
327-
rootStruct.misc.println(String.format("public Object %s(Class aClass) {", JBBPMapper.MAKE_CLASS_INSTANCE_METHOD_NAME));
327+
rootStruct.misc.println(String.format("public Object %s(Class<?> aClass) {", JBBPMapper.MAKE_CLASS_INSTANCE_METHOD_NAME));
328328
rootStruct.misc.incIndent();
329329

330330
for (final Struct c : rootStruct.children) {
@@ -1515,12 +1515,12 @@ public Builder disableGenerateFields() {
15151515
*
15161516
* @return a converter instance.
15171517
*/
1518-
public JBBPToJava6Converter build() {
1518+
public JBBPToJavaConverter build() {
15191519
this.lockBuilder = true;
15201520
if (this.mainClassName == null) {
15211521
throw new NullPointerException("Class name must not be null");
15221522
}
1523-
return new JBBPToJava6Converter(this);
1523+
return new JBBPToJavaConverter(this);
15241524
}
15251525
}
15261526

0 commit comments

Comments
 (0)