Skip to content

Commit a1a59f9

Browse files
authored
fix #980 (#987)
1 parent 59f184d commit a1a59f9

File tree

8 files changed

+16
-13
lines changed

8 files changed

+16
-13
lines changed

packages/react-bootstrap-table2/src/cell-event-delegater.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import _ from './utils';
2+
13
const events = [
24
'onClick',
35
'onDoubleClick',
@@ -23,7 +25,7 @@ export default ExtendBase =>
2325
delegate(attrs = {}) {
2426
const newAttrs = { ...attrs };
2527
Object.keys(attrs).forEach((attr) => {
26-
if (events.includes(attr)) {
28+
if (_.contains(events, attr)) {
2729
newAttrs[attr] = this.createDefaultEventHandler(attrs[attr]);
2830
}
2931
});

packages/react-bootstrap-table2/src/contexts/row-expand-context.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class RowExpandProvider extends React.Component {
2020
if (nextProps.expandRow) {
2121
const nextExpanded = nextProps.expandRow.expanded || this.state.expanded;
2222
const isClosing = this.state.expanded.reduce((acc, cur) => {
23-
if (!nextExpanded.includes(cur)) {
23+
if (!_.contains(nextExpanded, cur)) {
2424
acc.push(cur);
2525
}
2626
return acc;
@@ -42,7 +42,7 @@ class RowExpandProvider extends React.Component {
4242

4343
handleRowExpand = (rowKey, expanded, rowIndex, e) => {
4444
const { data, keyField, expandRow: { onExpand, onlyOneExpanding, nonExpandable } } = this.props;
45-
if (nonExpandable && nonExpandable.includes(rowKey)) {
45+
if (nonExpandable && _.contains(nonExpandable, rowKey)) {
4646
return;
4747
}
4848

packages/react-bootstrap-table2/src/props-resolver/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default ExtendBase =>
2222
if (!hiddenRows || hiddenRows.length === 0) return data;
2323
return data.filter((row) => {
2424
const key = _.get(row, keyField);
25-
return !hiddenRows.includes(key);
25+
return !_.contains(hiddenRows, key);
2626
});
2727
}
2828
};

packages/react-bootstrap-table2/src/row-expand/row-consumer.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
/* eslint react/prop-types: 0 */
22
import React from 'react';
33
import ExpandRow from './expand-row';
4+
import _ from '../utils';
45
import ExpansionContext from '../contexts/row-expand-context';
56

67
export default (Component) => {
78
const renderWithExpansion = (props, expandRow) => {
89
const key = props.value;
910

10-
const expanded = expandRow.expanded.includes(key);
11-
const isClosing = expandRow.isClosing.includes(key);
12-
const expandable = !expandRow.nonExpandable || !expandRow.nonExpandable.includes(key);
11+
const expanded = _.contains(expandRow.expanded, key);
12+
const isClosing = _.contains(expandRow.isClosing, key);
13+
const expandable = !expandRow.nonExpandable || !_.contains(expandRow.nonExpandable, key);
1314
return [
1415
<Component
1516
{ ...props }

packages/react-bootstrap-table2/src/row-selection/row-consumer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import SelectionContext from '../contexts/selection-context';
77
export default (Component) => {
88
const renderWithSelection = (props, selectRow) => {
99
const key = props.value;
10-
const selected = selectRow.selected.includes(key);
11-
const selectable = !selectRow.nonSelectable || !selectRow.nonSelectable.includes(key);
10+
const selected = _.contains(selectRow.selected, key);
11+
const selectable = !selectRow.nonSelectable || !_.contains(selectRow.nonSelectable, key);
1212

1313
let {
1414
style,

packages/react-bootstrap-table2/src/row/event-delegater.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export default ExtendBase =>
7474
delegate(attrs = {}) {
7575
const newAttrs = { ...attrs };
7676
Object.keys(attrs).forEach((attr) => {
77-
if (events.includes(attr)) {
77+
if (_.contains(events, attr)) {
7878
newAttrs[attr] = this.createDefaultEventHandler(attrs[attr]);
7979
}
8080
});

packages/react-bootstrap-table2/src/store/expand.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const expandableKeys = (data, keyField, skips = []) => {
2020
return data.map(row => _.get(row, keyField));
2121
}
2222
return data
23-
.filter(row => !skips.includes(_.get(row, keyField)))
23+
.filter(row => !_.contains(skips, _.get(row, keyField)))
2424
.map(row => _.get(row, keyField));
2525
};
2626

packages/react-bootstrap-table2/src/store/selection.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ export const selectableKeys = (data, keyField, skips = []) => {
2929
return data.map(row => _.get(row, keyField));
3030
}
3131
return data
32-
.filter(row => !skips.includes(_.get(row, keyField)))
32+
.filter(row => !_.contains(skips, _.get(row, keyField)))
3333
.map(row => _.get(row, keyField));
3434
};
3535

3636
export const unSelectableKeys = (selected, skips = []) => {
3737
if (skips.length === 0) {
3838
return [];
3939
}
40-
return selected.filter(x => skips.includes(x));
40+
return selected.filter(x => _.contains(skips, x));
4141
};
4242

4343
export const getSelectedRows = (data, keyField, selected) =>

0 commit comments

Comments
 (0)