Commit fa6e8f6
committed
Modify
```
Failure:
WebpackerManifestContainerTest#test_it_loads_JS_from_the_webpacker_container [/Users/tanimichi.tsukuru/ghq/github.com/reactjs/react-rails/test/react/server_rendering/webpacker_manifest_container_test.rb:20]:
Expected "...(snip)....js.map" to include "ExportDefaultComponent".
```
Now `webpacker:compile` doesn't contain components' name in the javascript_pack_tags. I think we shouldn't test the contents in `application.js` because it's an implementation detail of webpacker and depending on it makes our tests fragile.WebpackerManifestContainerTest
1 parent 415096a commit fa6e8f6
File tree
1 file changed
+2
-10
lines changed- test/react/server_rendering
1 file changed
+2
-10
lines changedLines changed: 2 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 13 | + | |
18 | 14 | | |
19 | 15 | | |
20 | 16 | | |
21 | 17 | | |
22 | 18 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 19 | + | |
28 | 20 | | |
29 | 21 | | |
30 | 22 | | |
| |||
0 commit comments