RI-7761 Fix connection indicator not updating when Redis reconnects #5305
+16
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pd-redis,
tptodorov and
valkirilov
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
redisinsight/ui/src/components/database-overview/hooks/useDatabaseOverview.ts
Outdated
Show resolved
Hide resolved
redisinsight/ui/src/components/database-overview/hooks/useDatabaseOverview.ts
Show resolved
Hide resolved
Contributor
Code Coverage - Integration Tests
|
Contributor
Code Coverage - Backend unit tests
Test suite run success2990 tests passing in 287 suites. Report generated by 🧪jest coverage report action from 7f64d4d |
valkirilov
previously approved these changes
Dec 4, 2025
pawelangelow
force-pushed
the
bugfix/RI-7761/fix-connection-indicator
branch
from
fe3ce3f to
44ad0e1
Compare
- Clear connectivity error on successful API response, avoiding stale closure issues where the callback captures an outdated value - Remove unused handleRefreshClick callback since loadData() is already called via onRefresh Fixes: #RI-7761
Clears stale connectivity error from previous database when user switches to a different database, preventing brief display of error indicator for healthy connections. References: #RI-7761
pawelangelow
force-pushed
the
bugfix/RI-7761/fix-connection-indicator
branch
from
44ad0e1 to
7f64d4d
Compare
Contributor
Code Coverage - Frontend unit tests
Test suite run success5467 tests passing in 703 suites. Report generated by 🧪jest coverage report action from 7f64d4d |
valkirilov
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed the connection indicator (red icon) in the Database Overview not automatically clearing when the Redis connection is restored.
The issue was that auto-refresh stopped making API calls while a connectivity error was present. Now, auto-refresh continues during errors and clears the error indicator automatically when the API succeeds.
Screenshots
Before (bug persists after Redis restart)
After (error clears automatically)
Testing
Closes #RI-7761
Pull Request opened by Augment Code with guidance from the PR author
Note
Keep overview auto-refresh polling and clear the connectivity error on successful fetch; remove handleRefreshClick and clear connectivity error during context reset.
useDatabaseOverviewto always dispatchgetDatabaseConfigInfoActionand clearconnectivityErroron successful response via callback; setslastRefreshTimeafter dispatch.handleRefreshClick;handleRefreshnow triggers data load directly.onRefreshClickedusage fromDatabaseOverviewand relies ononRefresh/onEnableAutoRefresh.resetDatabaseContextnow dispatchessetConnectivityError(null)during reset.handleRefreshClickand new behavior (expectingsetConnectivityError(null)after resets and ensuring refresh dispatches config fetch).Written by Cursor Bugbot for commit 7f64d4d. This will update automatically on new commits. Configure here.