Allow overriding connection class via keyword arguments (#1752)

Author: Maksim Novikov

redis/connection.py

@@ -1131,6 +1131,10 @@ class initializer. In the case of conflicting arguments, querystring
         arguments always win.
         """
         url_options = parse_url(url)
+
+        if "connection_class" in kwargs:
+            url_options["connection_class"] = kwargs["connection_class"]
+
         kwargs.update(url_options)
         return cls(**kwargs)
 

tests/test_connection_pool.py

@@ -445,6 +445,15 @@ def test_extra_querystring_options(self):
         assert pool.connection_class == redis.UnixDomainSocketConnection
         assert pool.connection_kwargs == {"path": "/socket", "a": "1", "b": "2"}
 
+    def test_connection_class_override(self):
+        class MyConnection(redis.UnixDomainSocketConnection):
+            pass
+
+        pool = redis.ConnectionPool.from_url(
+            'unix:///socket', connection_class=MyConnection
+        )
+        assert pool.connection_class == MyConnection
+
 
 @pytest.mark.skipif(not ssl_available, reason="SSL not installed")
 class TestSSLConnectionURLParsing:
@@ -455,6 +464,15 @@ def test_host(self):
             "host": "my.host",
         }
 
+    def test_connection_class_override(self):
+        class MyConnection(redis.SSLConnection):
+            pass
+
+        pool = redis.ConnectionPool.from_url(
+            'rediss://my.host', connection_class=MyConnection
+        )
+        assert pool.connection_class == MyConnection
+
     def test_cert_reqs_options(self):
         import ssl