clippy nursery 🍼 (almost)

Author: rene-d

2017/day1/day1.rs

@@ -5,8 +5,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle {
+    const fn new() -> Self {
+        Self {
             data: String::new(),
         }
     }

2017/day10/day10.rs

@@ -7,8 +7,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle {
+    const fn new() -> Self {
+        Self {
             data: String::new(),
         }
     }
@@ -17,7 +17,7 @@ impl Puzzle {
     fn configure(&mut self, path: &str) {
         let data = std::fs::read_to_string(path).unwrap();
 
-        self.data = data.trim().to_owned();
+        data.trim().clone_into(&mut self.data);
     }
 
     /// Solve part one.

2017/day11/day11.rs

@@ -10,8 +10,8 @@ const STEP_X: i32 = 1;
 const STEP_Y: i32 = 1;
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle {
+    const fn new() -> Self {
+        Self {
             data: String::new(),
             part1: 0,
             part2: 0,
@@ -26,7 +26,7 @@ impl Puzzle {
     }
 
     /// Determine the fewest number of steps to return to (0,0).
-    fn steps(x: i32, y: i32) -> u32 {
+    const fn steps(x: i32, y: i32) -> u32 {
         let mut x = x.abs();
         let mut y = y.abs();
         let mut steps = 0;

2017/day13/day13.rs

@@ -7,8 +7,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle {
+    fn new() -> Self {
+        Self {
             heights: HashMap::new(),
         }
     }

2017/day14/day14.rs

@@ -3,7 +3,7 @@
 use aoc::grid::Grid;
 use aoc::knot;
 
-fn count_ones(value: u8) -> u32 {
+const fn count_ones(value: u8) -> u32 {
     let mut count = 0;
     let mut value = value;
 
@@ -20,8 +20,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle { key: String::new() }
+    const fn new() -> Self {
+        Self { key: String::new() }
     }
 
     /// Get the puzzle input.

2017/day15/day15.rs

@@ -6,8 +6,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle { a: 0, b: 0 }
+    const fn new() -> Self {
+        Self { a: 0, b: 0 }
     }
 
     /// Get the puzzle input.

2017/day16/day16.rs

@@ -5,8 +5,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle { program: vec![] }
+    const fn new() -> Self {
+        Self { program: vec![] }
     }
 
     /// Get the puzzle input.

2017/day17/day17.rs

@@ -5,8 +5,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle { step: 0 }
+    const fn new() -> Self {
+        Self { step: 0 }
     }
 
     /// Get the puzzle input.

2017/day18/day18.rs

@@ -105,8 +105,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle { program: vec![] }
+    const fn new() -> Self {
+        Self { program: vec![] }
     }
 
     /// Get the puzzle input.

2017/day2/day2.rs

@@ -5,8 +5,8 @@ struct Puzzle {
 }
 
 impl Puzzle {
-    fn new() -> Puzzle {
-        Puzzle { data: vec![] }
+    const fn new() -> Self {
+        Self { data: vec![] }
     }
 
     /// Get the puzzle input.