Skip to content

Commit ab7c4db

Browse files
committed
build: fix protofile download
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
1 parent abbefd7 commit ab7c4db

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

CONTRIBUTING.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ As `step 0` make sure you have python 3.7+, [https://python-poetry.org/](poetry)
8585

8686
5. When you're done making changes, check that your changes pass linters and the tests::
8787

88-
$ poetry shell
89-
$ make ql2.proto
88+
$ poetry env activate
89+
$ make protobuf
9090
$ make format
9191
$ make lint
9292
$ make test

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ lint: ## run linters against the package
106106
pylint rethinkdb
107107
flake8 rethinkdb --count --show-source --statistics
108108

109-
.PHONY: ql2.proto
110-
ql2.proto: ## download and convert protobuf file
109+
.PHONY: protobuf
110+
protobuf: ## download and convert protobuf file
111111
curl -sqo ${TARGET_PROTO_FILE} ${PROTO_FILE_URL}
112112
python ${FILE_CONVERTER_NAME} -l python -i ${TARGET_PROTO_FILE} -o ${TARGET_CONVERTED_PROTO_FILE}
113113

scripts/convert_protofile.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ def convertFile(inputFile, outputFile, language):
8585
assert outputFile is not None and hasattr(outputFile, "write")
8686
assert language in languageDefs
8787

88-
messageRegex = re.compile("\s*(message|enum) (?P<name>\w+) \{")
89-
valueRegex = re.compile("\s*(?P<name>\w+)\s*=\s*(?P<value>\w+)")
90-
endRegex = re.compile("\s*\}")
88+
messageRegex = re.compile(r"\s*(message|enum) (?P<name>\w+) \{")
89+
valueRegex = re.compile(r"\s*(?P<name>\w+)\s*=\s*(?P<value>\w+)")
90+
endRegex = re.compile(r"\s*\}")
9191

9292
indentLevel = languageDefs[language]["initialIndentLevel"]
9393
lastIndentLevel = languageDefs[language]["initialIndentLevel"] - 1

0 commit comments

Comments
 (0)