Fix call-seq deduplicate for name overlap in aliases

Fix call-seq deduplicate of `Hash#value?` and `Hash#has_value?`.
When alias names have overlap, deduplicate didn't work correctly.

Author: tompng

lib/rdoc/code_object/any_method.rb

@@ -360,15 +360,25 @@ def deduplicate_call_seq(call_seq)
       ignore << is_alias_for.name
       ignore.concat is_alias_for.aliases.map(&:name)
     end
-    ignore.map! { |n| n =~ /\A\[/ ? /\[.*\]/ : n}
+
+    bracket_methods = ignore.grep(/\A\[/)
+    ignore -= bracket_methods
     ignore.delete(method_name)
-    ignore = Regexp.union(ignore)
 
-    matching = entries.reject do |entry|
-      entry =~ /^\w*\.?#{ignore}[$\(\s]/ or
-        entry =~ /\s#{ignore}\s/
+    if ignore.any?
+      ignore_union = Regexp.union(ignore)
+      entries.reject! do |entry|
+        entry =~ /^(\w*\.)?#{ignore_union}([\(\s]|$)/ or
+          entry =~ /\s#{ignore_union}\s/
+      end
+    end
+    if bracket_methods.any?
+      entries.reject! do |entry|
+        # Ignore `receiver[arg] -> return_type` `[](arg)` `[]`
+        entry.match?(/^\w*\[.*\]([\(\s]|$)/)
+      end
     end
 
-    matching.empty? ? nil : matching.join("\n")
+    entries.empty? ? nil : entries.join("\n")
   end
 end

test/rdoc/parser/c_test.rb

@@ -2107,6 +2107,30 @@ def test_scan_method_copy
     assert_match 'str === obj', equals3.call_seq
   end
 
+  def test_scan_method_copy_name_overlap
+    parser = util_parser <<~C
+      /*
+      *  call-seq:
+      *    has_value?(value) -> true or false
+      */
+      static VALUE
+      rb_hash_has_value(VALUE hash, VALUE val) { return Qtrue; }
+      Init_Hash(void)
+      {
+        rb_define_method(rb_cHash, "has_value?", rb_hash_has_value, 1);
+        rb_define_method(rb_cHash, "value?", rb_hash_has_value, 1);
+      }
+    C
+
+    parser.scan
+
+    hash = @store.classes_hash['Hash']
+    value_method = hash.method_list.find { |m| m.name == 'value?' }
+    has_value_method = hash.method_list.find { |m| m.name == 'has_value?' }
+    assert_nil value_method.call_seq
+    assert_equal "has_value?(value) -> true or false", has_value_method.call_seq
+  end
+
   def test_scan_order_dependent
     parser = util_parser <<-C
 void a(void) {