Merge #499: Take self by value

sanket1729 · sanket1729 · commit 45eb69dbccc6 · 2022-12-22T21:23:12.000-08:00
b069239 Take self by value (Tobin C. Harding) Pull request description: Clippy emits: warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value The method in question is private, change to take `self` by value. Requires no other changes. (Should have been part of the trivial clippy fixes :) ACKs for top commit: apoelstra: ACK b069239 Tree-SHA512: ff15ea9818323f799a917d3506454341d296d96c8be7e36606f7199e351c5843a17e43f1fd736bbef25e2916d5be15853643a61331cca5fc6962be7205c201fb
diff --git a/src/interpreter/mod.rs b/src/interpreter/mod.rs
@@ -92,7 +92,7 @@ enum BitcoinKey {
 }
 
 impl BitcoinKey {
-    fn to_pubkeyhash(&self, sig_type: SigType) -> hash160::Hash {
+    fn to_pubkeyhash(self, sig_type: SigType) -> hash160::Hash {
         match self {
             BitcoinKey::Fullkey(pk) => pk.to_pubkeyhash(sig_type),
             BitcoinKey::XOnlyPublicKey(pk) => pk.to_pubkeyhash(sig_type),

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ enum BitcoinKey {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`impl BitcoinKey {`
`95`		`- fn to_pubkeyhash(&self, sig_type: SigType) -> hash160::Hash {`
	`95`	`+ fn to_pubkeyhash(self, sig_type: SigType) -> hash160::Hash {`
`96`	`96`	`match self {`
`97`	`97`	`BitcoinKey::Fullkey(pk) => pk.to_pubkeyhash(sig_type),`
`98`	`98`	`BitcoinKey::XOnlyPublicKey(pk) => pk.to_pubkeyhash(sig_type),`