Remove unneeded calls to clone

Clippy emits two warnings related to unneeded calls to clone.

Author: tcharding

src/descriptor/mod.rs

@@ -1232,7 +1232,7 @@ mod tests {
             sequence: Sequence::from_height(100),
             witness: Witness::default(),
         };
-        let bare = Descriptor::new_bare(ms.clone()).unwrap();
+        let bare = Descriptor::new_bare(ms).unwrap();
 
         bare.satisfy(&mut txin, &satisfier).expect("satisfaction");
         assert_eq!(

src/descriptor/sortedmulti.rs

@@ -258,7 +258,7 @@ mod tests {
 
         let mut pks = Vec::new();
         for _ in 0..over {
-            pks.push(pk.clone());
+            pks.push(pk);
         }
 
         let res: Result<SortedMultiVec<PublicKey, Legacy>, Error> = SortedMultiVec::new(0, pks);

src/interpreter/inner.rs

@@ -820,7 +820,7 @@ mod tests {
             from_txdata(&spk, &script_sig, &empty_wit).expect("parse txdata");
         assert_eq!(inner, Inner::Script(miniscript, ScriptType::Sh));
         assert_eq!(stack, Stack::from(vec![]));
-        assert_eq!(script_code, Some(redeem_script.clone()));
+        assert_eq!(script_code, Some(redeem_script));
 
         // nonempty witness
         let wit = Witness::from_vec(vec![vec![]]);

src/miniscript/iter.rs

@@ -275,7 +275,7 @@ pub mod test {
         let preimage = vec![0xab as u8; 32];
         let sha256_hash = sha256::Hash::hash(&preimage);
         let sha256d_hash_rev = sha256d::Hash::hash(&preimage);
-        let mut sha256d_hash_bytes = sha256d_hash_rev.clone().into_inner();
+        let mut sha256d_hash_bytes = sha256d_hash_rev.into_inner();
         sha256d_hash_bytes.reverse();
         let sha256d_hash = sha256d::Hash::from_inner(sha256d_hash_bytes);
         let hash160_hash = hash160::Hash::hash(&preimage);

src/policy/semantic.rs

@@ -694,11 +694,8 @@ mod tests {
         assert_eq!(policy, Policy::Key("".to_owned()));
         assert_eq!(policy.relative_timelocks(), vec![]);
         assert_eq!(policy.absolute_timelocks(), vec![]);
-        assert_eq!(policy.clone().at_age(Sequence::ZERO), policy.clone());
-        assert_eq!(
-            policy.clone().at_age(Sequence::from_height(10000)),
-            policy.clone()
-        );
+        assert_eq!(policy.clone().at_age(Sequence::ZERO), policy);
+        assert_eq!(policy.clone().at_age(Sequence::from_height(10000)), policy);
         assert_eq!(policy.n_keys(), 1);
         assert_eq!(policy.minimum_n_keys(), Some(1));
 
@@ -711,14 +708,8 @@ mod tests {
             policy.clone().at_age(Sequence::from_height(999)),
             Policy::Unsatisfiable
         );
-        assert_eq!(
-            policy.clone().at_age(Sequence::from_height(1000)),
-            policy.clone()
-        );
-        assert_eq!(
-            policy.clone().at_age(Sequence::from_height(10000)),
-            policy.clone()
-        );
+        assert_eq!(policy.clone().at_age(Sequence::from_height(1000)), policy);
+        assert_eq!(policy.clone().at_age(Sequence::from_height(10000)), policy);
         assert_eq!(policy.n_keys(), 0);
         assert_eq!(policy.minimum_n_keys(), Some(0));
 
@@ -843,13 +834,13 @@ mod tests {
             policy
                 .clone()
                 .at_lock_time(LockTime::from_height(1000).expect("valid block height")),
-            policy.clone()
+            policy
         );
         assert_eq!(
             policy
                 .clone()
                 .at_lock_time(LockTime::from_height(10000).expect("valid block height")),
-            policy.clone()
+            policy
         );
         // Pass a UNIX timestamp to at_lock_time while policy uses a block height.
         assert_eq!(
@@ -906,13 +897,13 @@ mod tests {
             policy
                 .clone()
                 .at_lock_time(LockTime::from_time(500_000_010).expect("valid timestamp")),
-            policy.clone()
+            policy
         );
         assert_eq!(
             policy
                 .clone()
                 .at_lock_time(LockTime::from_time(500_000_012).expect("valid timestamp")),
-            policy.clone()
+            policy
         );
         assert_eq!(policy.n_keys(), 0);
         assert_eq!(policy.minimum_n_keys(), Some(0));
@@ -933,7 +924,6 @@ mod tests {
         // test liquid backup policy before the emergency timeout
         let backup_policy = StringPolicy::from_str("thresh(2,pk(A),pk(B),pk(C))").unwrap();
         assert!(!backup_policy
-            .clone()
             .entails(liquid_pol.clone().at_age(Sequence::from_height(4095)))
             .unwrap());
 
@@ -942,9 +932,7 @@ mod tests {
         let backup_policy_after_expiry =
             StringPolicy::from_str("and(older(4096),thresh(2,pk(A),pk(B),pk(C)))").unwrap();
         assert!(fed_pol.entails(liquid_pol.clone()).unwrap());
-        assert!(backup_policy_after_expiry
-            .entails(liquid_pol.clone())
-            .unwrap());
+        assert!(backup_policy_after_expiry.entails(liquid_pol).unwrap());
     }
 
     #[test]

src/psbt/mod.rs

@@ -1696,7 +1696,7 @@ mod tests {
             output: vec![],
         };
 
-        let mut psbt = Psbt::from_unsigned_tx(tx.clone()).unwrap();
+        let mut psbt = Psbt::from_unsigned_tx(tx).unwrap();
         assert_eq!(
             psbt.update_input_with_descriptor(0, &desc),
             Err(UtxoUpdateError::UtxoCheck),
@@ -1715,7 +1715,7 @@ mod tests {
             "matching non_witness_utxo"
         );
         non_witness_utxo.version = 0;
-        psbt.inputs[0].non_witness_utxo = Some(non_witness_utxo.clone());
+        psbt.inputs[0].non_witness_utxo = Some(non_witness_utxo);
         assert_eq!(
             psbt.update_input_with_descriptor(0, &desc),
             Err(UtxoUpdateError::UtxoCheck),
@@ -1748,7 +1748,7 @@ mod tests {
             }],
         };
 
-        let mut psbt = Psbt::from_unsigned_tx(tx.clone()).unwrap();
+        let mut psbt = Psbt::from_unsigned_tx(tx).unwrap();
         assert_eq!(
             psbt.update_output_with_descriptor(1, &desc),
             Err(OutputUpdateError::IndexOutOfBounds(1, 1)),