Skip to content

Commit 50b1fa2

Browse files
committed
Remove obsolete /authorize/github route
This hasn't been used for quite some time and has been replace with the `github-redirect.html` file instead.
1 parent 7ea5429 commit 50b1fa2

File tree

5 files changed

+2
-58
lines changed

5 files changed

+2
-58
lines changed

.env.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export GIT_REPO_URL=file://$PWD/tmp/index-bare
4242
# not logging into your crates.io instance.
4343
# When registering a new application on GitHub for use with your local
4444
# crates.io instance, be sure to set the callback url for that application
45-
# to the address `http://localhost:4200/authorize/github`.
45+
# to the address `http://localhost:4200/github-redirect.html`.
4646
export GH_CLIENT_ID=
4747
export GH_CLIENT_SECRET=
4848

app/router.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export default class Router extends EmberRouter {
88
}
99

1010
Router.map(function () {
11-
this.route('github-authorize', { path: '/authorize/github' });
1211
this.route('crates');
1312
this.route('crate', { path: '/crates/:crate_id' }, function () {
1413
this.route('versions');

app/routes/github-authorize.js

Lines changed: 0 additions & 24 deletions
This file was deleted.

docs/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ OAuth Applications](https://github.com/settings/developers) and click on the
463463

464464
- Application name: name your application whatever you'd like.
465465
- Homepage URL: `http://localhost:4200/`
466-
- Authorization callback URL: `http://localhost:4200/authorize/github`
466+
- Authorization callback URL: `http://localhost:4200/github-redirect.html`
467467

468468
Create the application, then take the Client ID ad Client Secret values and use
469469
them as the values of the `GH_CLIENT_ID` and `GH_CLIENT_SECRET` in your `.env`.

tests/routes/github-authorize-test.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)