msw: Migrate QUnit test suite to new @msw/data API

Author: Turbo87

tests/acceptance/api-token-test.js

@@ -11,42 +11,42 @@ import { visit } from '../helpers/visit-ignoring-abort';
 module('Acceptance | api-tokens', function (hooks) {
   setupApplicationTest(hooks);
 
-  function prepare(context) {
-    let user = context.db.user.create({
+  async function prepare(context) {
+    let user = await context.db.user.create({
       login: 'johnnydee',
       name: 'John Doe',
       email: 'john@doe.com',
       avatar: 'https://avatars2.githubusercontent.com/u/1234567?v=4',
     });
 
-    context.db.apiToken.create({
+    await context.db.apiToken.create({
       user,
       name: 'foo',
       createdAt: '2017-08-01T12:34:56',
       lastUsedAt: '2017-11-02T01:45:14',
     });
 
-    context.db.apiToken.create({
+    await context.db.apiToken.create({
       user,
       name: 'BAR',
       createdAt: '2017-11-19T17:59:22',
       lastUsedAt: null,
       expiredAt: '2017-12-19T17:59:22',
     });
 
-    context.db.apiToken.create({
+    await context.db.apiToken.create({
       user,
       name: 'recently expired',
       createdAt: '2017-08-01T12:34:56',
       lastUsedAt: '2017-11-02T01:45:14',
       expiredAt: '2017-11-19T17:59:22',
     });
 
-    context.authenticateAs(user);
+    await context.authenticateAs(user);
   }
 
   test('/me is showing the list of active API tokens', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     await visit('/settings/tokens');
     assert.strictEqual(currentURL(), '/settings/tokens');
@@ -85,7 +85,7 @@ module('Acceptance | api-tokens', function (hooks) {
   });
 
   test('API tokens can be revoked', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     await visit('/settings/tokens');
     assert.strictEqual(currentURL(), '/settings/tokens');
@@ -104,7 +104,7 @@ module('Acceptance | api-tokens', function (hooks) {
   });
 
   test('API tokens can be regenerated', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     await visit('/settings/tokens');
     assert.strictEqual(currentURL(), '/settings/tokens');
@@ -124,7 +124,7 @@ module('Acceptance | api-tokens', function (hooks) {
   });
 
   test('failed API tokens revocation shows an error', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     this.worker.use(
       http.delete('/api/v1/me/tokens/:id', function () {
@@ -146,7 +146,7 @@ module('Acceptance | api-tokens', function (hooks) {
   });
 
   test('new API tokens can be created', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     await visit('/settings/tokens');
     assert.strictEqual(currentURL(), '/settings/tokens');
@@ -161,7 +161,7 @@ module('Acceptance | api-tokens', function (hooks) {
 
     await click('[data-test-generate]');
 
-    let token = this.db.apiToken.findFirst({ where: { name: { equals: 'the new token' } } });
+    let token = this.db.apiToken.findFirst(q => q.where({ name: 'the new token' }));
     assert.ok(Boolean(token), 'API token has been created in the backend database');
 
     assert.dom('[data-test-api-token="4"] [data-test-name]').hasText('the new token');
@@ -173,15 +173,15 @@ module('Acceptance | api-tokens', function (hooks) {
   });
 
   test('API tokens are only visible in plaintext until the page is left', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     await visit('/settings/tokens');
     await click('[data-test-new-token-button]');
     await fillIn('[data-test-name]', 'the new token');
     await click('[data-test-scope="publish-update"]');
     await click('[data-test-generate]');
 
-    let token = this.db.apiToken.findFirst({ where: { name: { equals: 'the new token' } } });
+    let token = this.db.apiToken.findFirst(q => q.where({ name: 'the new token' }));
     assert.dom('[data-test-token]').hasText(token.token);
 
     // leave the API tokens page
@@ -193,7 +193,7 @@ module('Acceptance | api-tokens', function (hooks) {
   });
 
   test('navigating away while creating a token does not keep it in the list', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     await visit('/settings/tokens');
     assert.dom('[data-test-api-token]').exists({ count: 3 });

tests/acceptance/categories-test.js

@@ -14,12 +14,12 @@ module('Acceptance | categories', function (hooks) {
   test('listing categories', async function (assert) {
     this.owner.lookup('service:intl').locale = 'en';
 
-    this.db.category.create({ category: 'API bindings' });
-    let algos = this.db.category.create({ category: 'Algorithms' });
-    this.db.crate.create({ categories: [algos] });
-    let async = this.db.category.create({ category: 'Asynchronous' });
+    await this.db.category.create({ category: 'API bindings' });
+    let algos = await this.db.category.create({ category: 'Algorithms' });
+    await this.db.crate.create({ categories: [algos] });
+    let async = await this.db.category.create({ category: 'Asynchronous' });
     Array.from({ length: 15 }, () => this.db.crate.create({ categories: [async] }));
-    this.db.category.create({ category: 'Everything', crates_cnt: 1234 });
+    await this.db.category.create({ category: 'Everything', crates_cnt: 1234 });
 
     await visit('/categories');
 
@@ -35,14 +35,14 @@ module('Acceptance | categories', function (hooks) {
   test('listing categories (locale: de)', async function (assert) {
     this.owner.lookup('service:intl').locale = 'de';
 
-    this.db.category.create({ category: 'Everything', crates_cnt: 1234 });
+    await this.db.category.create({ category: 'Everything', crates_cnt: 1234 });
 
     await visit('/categories');
     assert.dom('[data-test-category="everything"] [data-test-crate-count]').hasText('1.234 crates');
   });
 
   test('category/:category_id index default sort is recent-downloads', async function (assert) {
-    this.db.category.create({ category: 'Algorithms' });
+    await this.db.category.create({ category: 'Algorithms' });
 
     await visit('/categories/algorithms');
 
@@ -53,8 +53,8 @@ module('Acceptance | categories', function (hooks) {
   });
 
   test('listing category slugs', async function (assert) {
-    this.db.category.create({ category: 'Algorithms', description: 'Crates for algorithms' });
-    this.db.category.create({ category: 'Asynchronous', description: 'Async crates' });
+    await this.db.category.create({ category: 'Algorithms', description: 'Crates for algorithms' });
+    await this.db.category.create({ category: 'Asynchronous', description: 'Async crates' });
 
     await visit('/category_slugs');
 

tests/acceptance/crate-deletion-test.js

@@ -9,12 +9,12 @@ module('Acceptance | crate deletion', function (hooks) {
   setupApplicationTest(hooks);
 
   test('happy path', async function (assert) {
-    let user = this.db.user.create();
-    this.authenticateAs(user);
+    let user = await this.db.user.create();
+    await this.authenticateAs(user);
 
-    let crate = this.db.crate.create({ name: 'foo' });
-    this.db.version.create({ crate });
-    this.db.crateOwnership.create({ crate, user });
+    let crate = await this.db.crate.create({ name: 'foo' });
+    await this.db.version.create({ crate });
+    await this.db.crateOwnership.create({ crate, user });
 
     await visit('/crates/foo');
     assert.strictEqual(currentURL(), '/crates/foo');
@@ -39,7 +39,7 @@ module('Acceptance | crate deletion', function (hooks) {
     let message = 'Crate foo has been successfully deleted.';
     assert.dom('[data-test-notification-message="success"]').hasText(message);
 
-    crate = this.db.crate.findFirst({ where: { name: { equals: 'foo' } } });
-    assert.strictEqual(crate, null);
+    crate = this.db.crate.findFirst(q => q.where({ name: 'foo' }));
+    assert.strictEqual(crate, undefined);
   });
 });

tests/acceptance/crate-dependencies-test.js

@@ -16,7 +16,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
   setupApplicationTest(hooks);
 
   test('shows the lists of dependencies', async function (assert) {
-    loadFixtures(this.db);
+    await loadFixtures(this.db);
 
     await visit('/crates/nanomsg/dependencies');
     assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies');
@@ -31,8 +31,8 @@ module('Acceptance | crate dependencies page', function (hooks) {
   });
 
   test('empty list case', async function (assert) {
-    let crate = this.db.crate.create({ name: 'nanomsg' });
-    this.db.version.create({ crate, num: '0.6.1' });
+    let crate = await this.db.crate.create({ name: 'nanomsg' });
+    await this.db.version.create({ crate, num: '0.6.1' });
 
     await visit('/crates/nanomsg/dependencies');
 
@@ -63,8 +63,8 @@ module('Acceptance | crate dependencies page', function (hooks) {
   });
 
   test('shows an error page if version is not found', async function (assert) {
-    let crate = this.db.crate.create({ name: 'foo' });
-    this.db.version.create({ crate, num: '2.0.0' });
+    let crate = await this.db.crate.create({ name: 'foo' });
+    await this.db.version.create({ crate, num: '2.0.0' });
 
     await visit('/crates/foo/1.0.0/dependencies');
     assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
@@ -75,8 +75,8 @@ module('Acceptance | crate dependencies page', function (hooks) {
   });
 
   test('shows error message if loading of dependencies fails', async function (assert) {
-    let crate = this.db.crate.create({ name: 'foo' });
-    this.db.version.create({ crate, num: '1.0.0' });
+    let crate = await this.db.crate.create({ name: 'foo' });
+    await this.db.version.create({ crate, num: '1.0.0' });
 
     this.worker.use(
       http.get('/api/v1/crates/:crate_name/:version_num/dependencies', () => HttpResponse.json({}, { status: 500 })),
@@ -91,16 +91,16 @@ module('Acceptance | crate dependencies page', function (hooks) {
   });
 
   test('hides description if loading of dependency details fails', async function (assert) {
-    let crate = this.db.crate.create({ name: 'nanomsg' });
-    let version = this.db.version.create({ crate, num: '0.6.1' });
+    let crate = await this.db.crate.create({ name: 'nanomsg' });
+    let version = await this.db.version.create({ crate, num: '0.6.1' });
 
-    let foo = this.db.crate.create({ name: 'foo', description: 'This is the foo crate' });
-    this.db.version.create({ crate: foo, num: '1.0.0' });
-    this.db.dependency.create({ crate: foo, version, req: '^1.0.0', kind: 'normal' });
+    let foo = await this.db.crate.create({ name: 'foo', description: 'This is the foo crate' });
+    await this.db.version.create({ crate: foo, num: '1.0.0' });
+    await this.db.dependency.create({ crate: foo, version, req: '^1.0.0', kind: 'normal' });
 
-    let bar = this.db.crate.create({ name: 'bar', description: 'This is the bar crate' });
-    this.db.version.create({ crate: bar, num: '2.3.4' });
-    this.db.dependency.create({ crate: bar, version, req: '^2.0.0', kind: 'normal' });
+    let bar = await this.db.crate.create({ name: 'bar', description: 'This is the bar crate' });
+    await this.db.version.create({ crate: bar, num: '2.3.4' });
+    await this.db.dependency.create({ crate: bar, version, req: '^2.0.0', kind: 'normal' });
 
     this.worker.use(http.get('/api/v1/crates', () => HttpResponse.json({}, { status: 500 })));
 

tests/acceptance/crate-following-test.js

@@ -10,28 +10,28 @@ import { setupApplicationTest } from 'crates-io/tests/helpers';
 module('Acceptance | Crate following', function (hooks) {
   setupApplicationTest(hooks);
 
-  function prepare(context, { loggedIn = true, following = false } = {}) {
+  async function prepare(context, { loggedIn = true, following = false } = {}) {
     let { db } = context;
 
-    let crate = db.crate.create({ name: 'nanomsg' });
-    db.version.create({ crate, num: '0.6.0' });
+    let crate = await db.crate.create({ name: 'nanomsg' });
+    await db.version.create({ crate, num: '0.6.0' });
 
     if (loggedIn) {
       let followedCrates = following ? [crate] : [];
-      let user = db.user.create({ followedCrates });
-      context.authenticateAs(user);
+      let user = await db.user.create({ followedCrates });
+      await context.authenticateAs(user);
     }
   }
 
   test("unauthenticated users don't see the follow button", async function (assert) {
-    prepare(this, { loggedIn: false });
+    await prepare(this, { loggedIn: false });
 
     await visit('/crates/nanomsg');
     assert.dom('[data-test-follow-button]').doesNotExist();
   });
 
   test('authenticated users see a loading spinner and can follow/unfollow crates', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     let followingDeferred = defer();
     this.worker.use(http.get('/api/v1/crates/:crate_id/following', () => followingDeferred.promise));
@@ -74,7 +74,7 @@ module('Acceptance | Crate following', function (hooks) {
   });
 
   test('error handling when loading following state fails', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     this.worker.use(http.get('/api/v1/crates/:crate_id/following', () => HttpResponse.json({}, { status: 500 })));
 
@@ -88,7 +88,7 @@ module('Acceptance | Crate following', function (hooks) {
   });
 
   test('error handling when follow fails', async function (assert) {
-    prepare(this);
+    await prepare(this);
 
     this.worker.use(http.put('/api/v1/crates/:crate_id/follow', () => HttpResponse.json({}, { status: 500 })));
 
@@ -100,7 +100,7 @@ module('Acceptance | Crate following', function (hooks) {
   });
 
   test('error handling when unfollow fails', async function (assert) {
-    prepare(this, { following: true });
+    await prepare(this, { following: true });
 
     this.worker.use(http.delete('/api/v1/crates/:crate_id/follow', () => HttpResponse.json({}, { status: 500 })));
 

tests/acceptance/crate-navtabs-test.js

@@ -13,8 +13,8 @@ module('Acceptance | crate navigation tabs', function (hooks) {
   setupApplicationTest(hooks);
 
   test('basic navigation between tabs works as expected', async function (assert) {
-    let crate = this.db.crate.create({ name: 'nanomsg' });
-    this.db.version.create({ crate, num: '0.6.1' });
+    let crate = await this.db.crate.create({ name: 'nanomsg' });
+    await this.db.version.create({ crate, num: '0.6.1' });
 
     await visit('/crates/nanomsg');
     assert.strictEqual(currentURL(), '/crates/nanomsg');