Rename krate::metadata::krate to show_minimal

Author: nightkr

src/controllers/krate/metadata.rs

@@ -180,7 +180,7 @@ pub fn show(req: &mut dyn RequestExt) -> EndpointResult {
 ///
 /// A minimal version of [`show`] that only covers the crate itself, without versions or catalog information
 /// (such as keywords and categories).
-pub fn krate(req: &mut dyn RequestExt) -> EndpointResult {
+pub fn show_minimal(req: &mut dyn RequestExt) -> EndpointResult {
     let name = &req.params()["crate_id"];
     let conn = req.db_read_only()?;
     let krate: Crate = Crate::by_name(name).first(&*conn)?;

src/router.rs

@@ -36,7 +36,7 @@ pub fn build_router(app: &App) -> RouteBuilder {
 
     // Routes used by the frontend
     api_router.get("/crates/:crate_id", C(krate::metadata::show));
-    api_router.get("/crates/:crate_id/crate", C(krate::metadata::krate));
+    api_router.get("/crates/:crate_id/crate", C(krate::metadata::show_minimal));
     api_router.get("/crates/:crate_id/:version", C(version::metadata::show));
     api_router.get(
         "/crates/:crate_id/:version/readme",

src/tests/krate/krate.rs

@@ -1,7 +1,6 @@
 mod dependencies;
 mod downloads;
 mod following;
-mod krate;
 mod owners;
 mod publish;
 mod reverse_dependencies;

src/tests/krate/mod.rs

@@ -68,6 +68,50 @@ fn show() {
     );
 }
 
+#[test]
+fn show_minimal() {
+    let (app, anon, user) = TestApp::init().with_user();
+    let user = user.as_model();
+
+    let krate = app.db(|conn| {
+        use cargo_registry::schema::versions;
+        use diesel::{update, ExpressionMethods};
+
+        let krate = CrateBuilder::new("foo_show_minimal", user.id)
+            .description("description")
+            .documentation("https://example.com")
+            .homepage("http://example.com")
+            .version(VersionBuilder::new("1.0.0"))
+            .version(VersionBuilder::new("0.5.0"))
+            .version(VersionBuilder::new("0.5.1"))
+            .keyword("kw1")
+            .downloads(20)
+            .recent_downloads(10)
+            .expect_build(conn);
+
+        // Make version 1.0.0 mimic a version published before we started recording who published
+        // versions
+        let none: Option<i32> = None;
+        update(versions::table)
+            .filter(versions::num.eq("1.0.0"))
+            .set(versions::published_by.eq(none))
+            .execute(conn)
+            .unwrap();
+
+        krate
+    });
+
+    let json = anon.show_crate_minimal("foo_show_minimal");
+    assert_eq!(json.name, krate.name);
+    assert_eq!(json.id, krate.name);
+    assert_eq!(json.description, krate.description);
+    assert_eq!(json.homepage, krate.homepage);
+    assert_eq!(json.documentation, krate.documentation);
+    assert_eq!(json.keywords, None);
+    assert_eq!(json.recent_downloads, None);
+    assert_eq!(json.versions, None);
+}
+
 #[test]
 fn block_bad_documentation_url() {
     let (app, anon, user) = TestApp::init().with_user();