Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Nov 17, 2025

Next step towards #1560.

Idea is:

  • when we just proxy the asset from S3 directly, we can use the etag we get from the S3 API
  • when the asset is fetched out of an archive, we can generate a valid etag based on the full archive etag + the range.

The next step after is trying to figure out an etag for rustdoc pages, which finally could give us the gains laid out in #1560 .

I feel like there is also some duplication around conditional-get handling, but I want to see the rustdoc part first before I start reducing the duplication.

I changed the format of the Last-Modified header too, it looks like using UTC is against RFC, and GMT would be correct.

@syphar syphar requested a review from a team as a code owner November 17, 2025 05:53
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 17, 2025
@syphar syphar self-assigned this Nov 17, 2025
@syphar syphar marked this pull request as draft November 17, 2025 05:54
@syphar syphar changed the title Etag static WIP: set etags for static resources Nov 17, 2025
@syphar syphar force-pushed the etag-static branch 4 times, most recently from b0abca9 to 9a9dfc1 Compare November 21, 2025 23:05
@syphar syphar force-pushed the etag-static branch 2 times, most recently from fd1801a to b951647 Compare November 23, 2025 19:15
@syphar syphar changed the title WIP: set etags for static resources set & handle etags/if-none-match for first rustdoc assets Nov 23, 2025
@syphar syphar force-pushed the etag-static branch 2 times, most recently from 6e73ef0 to b1afdd1 Compare November 24, 2025 06:01
@syphar syphar marked this pull request as ready for review November 24, 2025 06:46
@syphar
Copy link
Member Author

syphar commented Nov 24, 2025

@GuillaumeGomez have you seen this one here?

@GuillaumeGomez
Copy link
Member

Now I did. :)

@syphar syphar merged commit 855b164 into rust-lang:main Nov 26, 2025
12 checks passed
@syphar syphar deleted the etag-static branch November 26, 2025 06:11
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 26, 2025
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants