Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Nov 22, 2025

The first step of #1560, extracted from #3006.

Can save quite a bit of transfer time for slow connections, but also saves time between CDN & origin. Of course, not specifically for these files, it's just the ones I started with.

Generally I want to try not to use the often "simple" etag impl that would aways generate the full html, then MD5-Hash it, and only then comparing it with If-None-Match. Better is to work with an ETag that can be generated without fetching the actual content.

Next steps after this:

  • use / reuse the ETag the S3 API already gives us, to add ETag / If-None-Match to rustdoc asset handlers (toolchain & invocation)
  • generate an ETag for rustdoc html pages, my current hunch is that we could implement that by using

@syphar syphar requested a review from a team as a code owner November 22, 2025 10:21
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 22, 2025
@GuillaumeGomez
Copy link
Member

We keep adding more deps. T_T

Build time (from clean) on my computer is getting in high numbers.

@syphar syphar self-assigned this Nov 22, 2025
@syphar syphar merged commit 46df4db into rust-lang:master Nov 22, 2025
11 checks passed
@syphar syphar deleted the etag-static-2 branch November 22, 2025 11:03
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 22, 2025
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants