Deprioritize older releases when new ones are added and refactor get_new_crates method #3065
+473
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Carbonhell
commented
Dec 4, 2025
| WHERE | ||
| name = $2 | ||
| AND version != $3 | ||
| AND attempt < $4 |
Contributor
Author
There was a problem hiding this comment.
If I understood the code correctly judging by other existing queries, this is basically a check for failed builds - is my understanding correct?
Member
There was a problem hiding this comment.
Yes, partially.
we have certain "pre-build" errors where we have these re-attempts.
Example:
a workspace is released where the crates depend on each other. We don't know in which order they come into the build queue, so we just retry later for certain failures.
"normal" build failures (compile errors) don't stay in this table.
( all of that being said, I'll think longer about us removing all builds from the queue, I have a hunch that this is because of some legacy limitation we don't have any more)
Carbonhell
force-pushed
the
tweak/deprioritize-older-releases
branch
from
fa532b0 to
744ab80
Compare
refactor(queue): break up get_new_crates() in smaller methods to facilitate testing
Carbonhell
force-pushed
the
tweak/deprioritize-older-releases
branch
from
744ab80 to
308726c
Compare
syphar
requested changes
Dec 5, 2025
chore(tracing): update tracing macro usages to use structured fields instead of string interpolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3064 .
To facilitate testing, I decided to split up the
get_new_cratesmethod in smaller units. The actual change that updates the priority for older releases is contained in thedeprioritize_other_releasesmethod, which is called when only a new crate is processed. This logic is only invoked when processing new crate versions are found by the registry watcher.For the refactor, a point worthy of note relates to the removal of manual
report_errorcalls, in favor of propagating the error to the caller, since they're already reported in the registry watcher entrypoint - this does not include calls todeprioritize_other_releasesandqueue_crate_invalidation, for which a failure can be logged without killing the watcher.The tests introduced are quite simple - let me know if more are needed!