Skip to content

Commit cec000f

Browse files
reduce unnecessary disassembly
1 parent 4e26eed commit cec000f

File tree

1 file changed

+8
-24
lines changed

1 file changed

+8
-24
lines changed

crates/ide-assists/src/handlers/add_missing_lifetime.rs

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
use ide_db::{FxIndexSet, source_change::SourceChangeBuilder};
22
use syntax::{
3-
NodeOrToken, SyntaxElement, SyntaxNode, SyntaxToken, T,
3+
NodeOrToken, T,
44
ast::{
5-
self, AstNode, HasGenericParams, HasName, Lifetime,
5+
self, AstNode, HasGenericParams, HasName,
66
make::{self, tokens},
77
syntax_factory::SyntaxFactory,
88
},
@@ -191,28 +191,12 @@ fn add_lifetime_to_refs(
191191
for r#ref in refs_without_lifetime {
192192
let Some(amp_token) = r#ref.amp_token() else { continue };
193193
let lifetime = make.lifetime(lifetime_text);
194-
insert_elements_after(
195-
&NodeOrToken::Token(amp_token),
196-
&lifetime,
197-
vec![lifetime.syntax().clone().into(), tokens::single_space().into()],
198-
ctx,
199-
editor,
200-
builder,
201-
);
202-
}
203-
}
204-
205-
fn insert_elements_after(
206-
node_or_token: &NodeOrToken<SyntaxNode, SyntaxToken>,
207-
lifetime: &Lifetime,
208-
elements: Vec<SyntaxElement>,
209-
ctx: &AssistContext<'_>,
210-
editor: &mut SyntaxEditor,
211-
builder: &mut SourceChangeBuilder,
212-
) {
213-
editor.insert_all(Position::after(node_or_token), elements);
214-
if let Some(cap) = ctx.config.snippet_cap {
215-
editor.add_annotation(lifetime.syntax(), builder.make_placeholder_snippet(cap));
194+
let node_or_token = &NodeOrToken::Token(amp_token);
195+
let elements = vec![lifetime.syntax().clone().into(), tokens::single_space().into()];
196+
editor.insert_all(Position::after(node_or_token), elements);
197+
if let Some(cap) = ctx.config.snippet_cap {
198+
editor.add_annotation(lifetime.syntax(), builder.make_placeholder_snippet(cap));
199+
};
216200
}
217201
}
218202

0 commit comments

Comments
 (0)