make this an unstable flag instead

Author: Mrmaxmeier

compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs

@@ -639,7 +639,8 @@ pub fn file_metadata<'ll>(cx: &CodegenCx<'ll, '_>, source_file: &SourceFile) ->
         };
         let hash_value = hex_encode(source_file.src_hash.hash_bytes());
 
-        let source = cx.sess().opts.cg.embed_source.then_some(()).and(source_file.src.as_ref());
+        let source =
+            cx.sess().opts.unstable_opts.embed_source.then_some(()).and(source_file.src.as_ref());
 
         unsafe {
             llvm::LLVMRustDIBuilderCreateFile(

compiler/rustc_session/src/options.rs

@@ -1489,8 +1489,6 @@ options! {
         "import library generation tool (ignored except when targeting windows-gnu)"),
     embed_bitcode: bool = (true, parse_bool, [TRACKED],
         "emit bitcode in rlibs (default: yes)"),
-    embed_source: bool = (false, parse_bool, [TRACKED],
-        "embed source text in DWARF debug sections (default: no)"),
     extra_filename: String = (String::new(), parse_string, [UNTRACKED],
         "extra data to put in each output filename"),
     force_frame_pointers: FramePointer = (FramePointer::MayOmit, parse_frame_pointer, [TRACKED],
@@ -1682,6 +1680,8 @@ options! {
         them only if an error has not been emitted"),
     ehcont_guard: bool = (false, parse_bool, [TRACKED],
         "generate Windows EHCont Guard tables"),
+    embed_source: bool = (false, parse_bool, [TRACKED],
+        "embed source text in DWARF debug sections (default: no)"),
     emit_stack_sizes: bool = (false, parse_bool, [UNTRACKED],
         "emit a section containing stack size metadata (default: no)"),
     emit_thin_lto: bool = (true, parse_bool, [TRACKED],

compiler/rustc_session/src/session.rs

@@ -1304,7 +1304,7 @@ fn validate_commandline_args_with_session_available(sess: &Session) {
 
     let dwarf_version =
         sess.opts.unstable_opts.dwarf_version.unwrap_or(sess.target.default_dwarf_version);
-    if sess.opts.cg.embed_source && dwarf_version < 5 {
+    if sess.opts.unstable_opts.embed_source && dwarf_version < 5 {
         sess.dcx().emit_err(errors::EmbedSourceInsufficientDwarfVersion { dwarf_version });
     }
 

src/doc/rustc/src/codegen-options/index.md

@@ -146,17 +146,6 @@ at start-up, because the combination is invalid.
 > reason for that is that it's how it was for rustc 1.44 and prior. In 1.45 this
 > option was added to turn off what had always been the default.
 
-## embed-source
-
-This flag controls whether the compiler embeds the program source code text into
-object debug info section. It takes one of the following values:
-
-* `y`, `yes`, `on` or `true`: put source code in debug info.
-* `n`, `no`, `off`, `false` or no value: omit source code from debug info (the default).
-
-`-C embed-source` requires DWARFv5. Use `-Zdwarf-version` to control the
-compiler's DWARF target version.
-
 ## extra-filename
 
 This option allows you to put extra data in each output filename. It takes a

src/doc/unstable-book/src/compiler-flags/embed-source.md

@@ -0,0 +1,10 @@
+# `embed-source`
+
+This flag controls whether the compiler embeds the program source code text into
+object debug info section. It takes one of the following values:
+
+* `y`, `yes`, `on` or `true`: put source code in debug info.
+* `n`, `no`, `off`, `false` or no value: omit source code from debug info (the default).
+
+`-C embed-source` requires DWARFv5 and is only supported with the LLVM backend.
+Use `-Z dwarf-version=5` to control the compiler's DWARF target version.