Skip to content

Commit 97c3fd0

Browse files
committed
Split the x64 benchmark set into two
1 parent 0f81ee0 commit 97c3fd0

File tree

2 files changed

+29
-14
lines changed

2 files changed

+29
-14
lines changed

collector/src/benchmark_set/mod.rs

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,30 @@ pub fn get_benchmark_sets_for_target(target: Target) -> Vec<BenchmarkSet> {
5353
BenchmarkSetMember::CompileBenchmark(BenchmarkName::from(name))
5454
}
5555

56+
let stable = vec![
57+
compile(CARGO),
58+
compile(ENCODING),
59+
compile(FUTURES),
60+
compile(HTML5EVER),
61+
compile(INFLATE),
62+
compile(PISTON_IMAGE),
63+
compile(REGEX),
64+
compile(SYN),
65+
compile(TOKIO_WEBPUSH_SIMPLE),
66+
];
67+
5668
match target {
5769
Target::X86_64UnknownLinuxGnu => {
58-
let all = vec![
70+
// Set 0 automatically runs runtime benchmarks and the rustc benchmark, so it should
71+
// receive less compile-time benchmarks to balance.
72+
// Set 0 also runs all stable benchmarks, but those are separate and we don't
73+
// really care about benchmarking "performance" for them, so we don't bother splitting
74+
// them up.
75+
let set_0 = vec![
5976
compile(AWAIT_CALL_TREE),
77+
compile(CARGO_0_87_1),
6078
compile(BITMAPS_3_2_1),
6179
compile(BITMAPS_3_2_1_NEW_SOLVER),
62-
compile(CARGO),
63-
compile(CARGO_0_87_1),
6480
compile(CLAP_DERIVE_4_5_32),
6581
compile(COERCIONS),
6682
compile(CRANELIFT_CODEGEN_0_119_0),
@@ -69,19 +85,17 @@ pub fn get_benchmark_sets_for_target(target: Target) -> Vec<BenchmarkSet> {
6985
compile(DEEPLY_NESTED_MULTI),
7086
compile(DERIVE),
7187
compile(DIESEL_2_2_10),
72-
compile(ENCODING),
7388
compile(EXTERNS),
7489
compile(EZA_0_21_2),
75-
compile(FUTURES),
90+
];
91+
let set_1 = vec![
7692
compile(HELLOWORLD),
7793
compile(HELLOWORLD_TINY),
78-
compile(HTML5EVER),
7994
compile(HTML5EVER_0_31_0),
8095
compile(HTML5EVER_0_31_0_NEW_SOLVER),
8196
compile(HYPER_1_6_0),
8297
compile(IMAGE_0_25_6),
8398
compile(INCLUDE_BLOB),
84-
compile(INFLATE),
8599
compile(ISSUE_46449),
86100
compile(ISSUE_58319),
87101
compile(ISSUE_88862),
@@ -91,9 +105,7 @@ pub fn get_benchmark_sets_for_target(target: Target) -> Vec<BenchmarkSet> {
91105
compile(MATCH_STRESS),
92106
compile(NALGEBRA_0_33_0),
93107
compile(NALGEBRA_0_33_0_NEW_SOLVER),
94-
compile(PISTON_IMAGE),
95108
compile(PROJECTION_CACHING),
96-
compile(REGEX),
97109
compile(REGEX_AUTOMATA_0_4_8),
98110
compile(REGRESSION_31157),
99111
compile(RIPGREP_14_1_1),
@@ -103,11 +115,9 @@ pub fn get_benchmark_sets_for_target(target: Target) -> Vec<BenchmarkSet> {
103115
compile(SERDE_1_0_219_THREADS4),
104116
compile(SERDE_DERIVE_1_0_219),
105117
compile(STM32F4_0_15_1),
106-
compile(SYN),
107118
compile(SYN_2_0_101),
108119
compile(SYN_2_0_101_NEW_SOLVER),
109120
compile(TOKEN_STREAM_STRESS),
110-
compile(TOKIO_WEBPUSH_SIMPLE),
111121
compile(TT_MUNCHER),
112122
compile(TUPLE_STRESS),
113123
compile(TYPENUM_1_18_0),
@@ -118,7 +128,12 @@ pub fn get_benchmark_sets_for_target(target: Target) -> Vec<BenchmarkSet> {
118128
compile(WF_PROJECTION_STRESS_65510),
119129
compile(WG_GRAMMAR),
120130
];
121-
vec![BenchmarkSet { members: all }]
131+
vec![
132+
BenchmarkSet {
133+
members: stable.into_iter().chain(set_0).collect(),
134+
},
135+
BenchmarkSet { members: set_1 },
136+
]
122137
}
123138
}
124139
}

site/src/job_queue/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -858,8 +858,8 @@ mod tests {
858858
.unwrap()
859859
.remove("foo")
860860
.unwrap();
861-
// runtime + rustc + 4 compile-time jobs
862-
assert_eq!(jobs.len(), 6);
861+
// runtime + rustc + 8 compile-time jobs (two x64 sets)
862+
assert_eq!(jobs.len(), 10);
863863

864864
Ok(ctx)
865865
})

0 commit comments

Comments
 (0)