-
Notifications
You must be signed in to change notification settings - Fork 994
dist: bump rustup version to v1.29.0
#4513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
PS: I understand that this version is not final, but any suggestion regarding the wording/phrasing/format of the changelog is greatly appreciated :) |
bcc97ee to
ac5c68f
Compare
19f4ecb to
b418650
Compare
b418650 to
7856171
Compare
|
@ChrisDenton Would you mind having a look? Many thanks in advance :) |
7856171 to
a736027
Compare
ChrisDenton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording looks good to me.
| - You can use the `RUSTUP_CONCURRENT_DOWNLOADS` environment variable to | ||
| adjust the number of concurrent downloads to better reflect the needs of | ||
| your specific environment. Particularly, you may set the value to `1` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest we mention the default value here?
|
|
||
| - `rustup check` will check for toolchain updates concurrently. [pr#4388] | ||
|
|
||
| - `rustup update` and `rustup toolchain` subcommands will download toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is more important/a bigger win for most usage than the rustup check changes, and so merits moving up?
| - `rustup update` and `rustup toolchain` subcommands will unpack components | ||
| of a toolchain while others are being downloaded. [pr#4471] [pr#4605] | ||
|
|
||
| - `rustup` now uses `indicatif`-based progress bars for toolchain update | ||
| checks and downloads. This provides not only a more async-friendly UI solution, | ||
| but also a more consistent and visually appealing experience for various | ||
| commands like `rustup check`, `rustup update`, and `rustup toolchain install`. | ||
| [pr#4388] [pr#4426] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like these are really all part of the same improvement in experience, and I don't think it makes sense to have separate bullet points from the user's point of view.
This is the 1st PR for the
1.29.0beta release according to our release process.Checklist
Draft the release blog post.(Not required, since this is a beta release.)