Replace withNewerVersions with supersedes

This commit removes withNewerVersions and replaces the one usage of it
with a new function supersedes, which checks whether an update matches
another while having a newer nextVersion.

withNewerVersions was a little awkward to update to work with us having
changed some Versions to VersionWithFirstSeens, because it accepts a
list of Versions (rather than just producing one).

It was originally added in response to [this PR
comment](#1667 (comment)),
but we reckon replacing it with a slightly different check of the
group and artifact IDs makes for clearer, more explicit code. We
think (though it’s somewhat hard to tell) that this doesn’t remove any
existing functionality: part of the argument for adding
withNewerVersions in the first place was to support Update.Group, but it
appears to only be called for Update.Singles.

Author: emdash-ie

modules/core/src/main/scala/org/scalasteward/core/data/Update.scala

@@ -77,12 +77,9 @@ object Update {
       s"$groupId:$artifacts : $versions"
     }
 
-    def withNewerVersions(versions: Nel[Version]): Update.Single = this match {
-      case s @ ForArtifactId(_, _, _, _) =>
-        s.copy(newerVersions = versions)
-      case ForGroupId(forArtifactIds) =>
-        ForGroupId(forArtifactIds.map(_.copy(newerVersions = versions)))
-    }
+    def supersedes(that: Update.Single): Boolean =
+      this.groupAndMainArtifactId == that.groupAndMainArtifactId
+        && this.nextVersion > that.nextVersion
   }
 
   final case class ForArtifactId(

modules/core/src/main/scala/org/scalasteward/core/nurture/PullRequestRepository.scala

@@ -71,9 +71,7 @@ final class PullRequestRepository[F[_]](kvStore: KeyValueStore[F, Repo, Map[Uri,
     kvStore.getOrElse(repo, Map.empty).map {
       _.collect {
         case (url, Entry(baseSha1, u: Update.Single, state, _, number, updateBranch))
-            if state === PullRequestState.Open &&
-              u.withNewerVersions(update.newerVersions) === update &&
-              u.nextVersion < update.nextVersion =>
+            if state === PullRequestState.Open && update.supersedes(u) =>
           for {
             number <- number
             branch = updateBranch.getOrElse(git.branchFor(u, repo.branch))