WIP: Disable WUnused for params of non-private defs

Author: szymon-rd

compiler/src/dotty/tools/dotc/transform/CheckUnused.scala

@@ -118,6 +118,10 @@ class CheckUnused private (phaseMode: CheckUnused.PhaseMode, suffix: String, _ke
 
   override def prepareForDefDef(tree: tpd.DefDef)(using Context): Context =
     unusedDataApply{ ud =>
+      if !tree.rawMods.is(Private) then
+        tree.termParamss.flatten.foreach { p =>
+          ud.addIgnoredParam(p.symbol)
+        }
       import ud.registerTrivial
       tree.registerTrivial
       traverseAnnotations(tree.symbol)
@@ -350,6 +354,8 @@ object CheckUnused:
     /** Trivial definitions, avoid registering params */
     private val trivialDefs = MutSet[Symbol]()
 
+    private val paramsToSkip = MutSet[Symbol]()
+
     /**
      * Push a new Scope of the given type, executes the given Unit and
      * pop it back to the original type.
@@ -396,6 +402,10 @@ object CheckUnused:
     def removeIgnoredUsage(sym: Symbol)(using Context): Unit =
       doNotRegister --= sym.everySymbol
 
+    def addIgnoredParam(sym: Symbol)(using Context): Unit =
+      paramsToSkip += sym
+
+
 
     /** Register an import */
     def registerImport(imp: tpd.Import)(using Context): Unit =
@@ -411,7 +421,7 @@ object CheckUnused:
         if memDef.isValidParam then
           if memDef.symbol.isOneOf(GivenOrImplicit) then
             implicitParamInScope += memDef
-          else
+          else if !paramsToSkip.contains(memDef.symbol) then
             explicitParamInScope += memDef
         else if currScopeType.top == ScopeType.Local then
           localDefInScope += memDef

tests/neg-custom-args/fatal-warnings/i15503-scala2/scala2-t11681.scala

@@ -9,7 +9,7 @@ trait InterFace {
 }
 
 trait BadAPI extends InterFace {
-  def f(a: Int,
+  private def f(a: Int,
         b: String,               // error
         c: Double): Int = {
     println(c)