Merge pull request #2423 from abeln/local-var

Fix #2368: local variables must be initialized

Author: DarkDimius

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -490,7 +490,10 @@ object messages {
            |${"var a = _"}
            |
            |Note that this use of `_` is not placeholder syntax,
-           |but an uninitialized var definition"""
+           |but an uninitialized var definition.
+           |Only fields can be left uninitialized in this manner; local variables
+           |must be initialized.
+           |"""
   }
 
   case class IllegalStartSimpleExpr(illegalToken: String)(implicit ctx: Context)

compiler/src/dotty/tools/dotc/typer/RefChecks.scala

@@ -774,6 +774,7 @@ class RefChecks extends MiniPhase { thisTransformer =>
 
   import tpd._
   import reporting.diagnostic.messages.ForwardReferenceExtendsOverDefinition
+  import dotty.tools.dotc.reporting.diagnostic.messages.UnboundPlaceholderParameter
 
   override def phaseName: String = "refchecks"
 
@@ -796,12 +797,19 @@ class RefChecks extends MiniPhase { thisTransformer =>
     override def transformValDef(tree: ValDef)(implicit ctx: Context, info: TransformerInfo) = {
       checkDeprecatedOvers(tree)
       val sym = tree.symbol
-      if (sym.exists && sym.owner.isTerm && !sym.is(Lazy))
-        currentLevel.levelAndIndex.get(sym) match {
-          case Some((level, symIdx)) if symIdx <= level.maxIndex =>
-            ctx.error(ForwardReferenceExtendsOverDefinition(sym, level.refSym), level.refPos)
+      if (sym.exists && sym.owner.isTerm) {
+        tree.rhs match {
+          case Ident(nme.WILDCARD) => ctx.error(UnboundPlaceholderParameter(), sym.pos)
           case _ =>
         }
+        if (!sym.is(Lazy)) {
+          currentLevel.levelAndIndex.get(sym) match {
+            case Some((level, symIdx)) if symIdx <= level.maxIndex =>
+              ctx.error(ForwardReferenceExtendsOverDefinition(sym, level.refSym), level.refPos)
+            case _ =>
+          }
+        }
+      }
       tree
     }
 

tests/neg/t2368.scala

@@ -0,0 +1,5 @@
+class C {
+  def foo() = {
+    var x: String = _ // error: local variables can't be left uninitialized
+  }
+}

tests/pos/t2368.scala

@@ -0,0 +1,4 @@
+class C {
+  // A `var` field can be left uninitialized.
+  var x: String = _
+}