Scala3doc: fix all warnings

Author: abgruszecki

scala3doc/src/main/scala/dotty/dokka/DottyDokkaPlugin.scala

@@ -133,7 +133,9 @@ class DottyDokkaPlugin extends DokkaJavaPlugin:
 
   val muteDefaultSourceLinksTransformer = extend(
     _.extensionPoint(CoreExtensions.INSTANCE.getPageTransformer)
-    .fromInstance(identity)
+    .fromInstance(new PageTransformer {
+      override def invoke(root: RootPageNode) = root
+    })
     .overrideExtension(dokkaBase.getSourceLinksTransformer)
     .name("muteDefaultSourceLinksTransformer")
   )    

scala3doc/src/main/scala/dotty/dokka/tasty/ScalaDocSupport.scala

@@ -10,7 +10,7 @@ import dotty.dokka.ScalaTagWrapper
 import comments.{kt, dkk}
 
 trait ScaladocSupport { self: TastyParser =>
-  import reflect.{given _, _}
+  import reflect._
 
   def parseComment(
     commentNode: reflect.Comment,

scala3doc/src/main/scala/dotty/dokka/transformers/InheritanceInformationTransformer.scala

@@ -24,5 +24,5 @@ class InheritanceInformationTransformer(val ctx: DokkaContext) extends Documenta
                 c.parents.map(_._2 -> selfLink)
 
             c.allMembers.flatMap(getSupertypes) ++ selfMapping
-        case other => List.empty
-    }
+        case null => List.empty
+    }

scala3doc/src/main/scala/dotty/dokka/transformers/ScalaSourceLinksTransformer.scala

@@ -34,7 +34,8 @@ class ScalaSourceLinksTransformer(
 
     override def invoke(input: DModule, context: DokkaContext): DModule = 
         input.updateMembers { 
-            case c: Member with WithSources with WithExtraProperties[Member] => 
+            case c0: (Member & WithSources & WithExtraProperties[_]) => 
+                val c = c0.asInstanceOf[Member & WithSources & WithExtraProperties[Member]]
                 c.withNewExtras(c.getExtra plus getSourceLinks(c))
             case c => c
         }
@@ -57,4 +58,4 @@ class ScalaSourceLinksTransformer(
             link.url + s.path.split(link.path)(1) + link.lineSuffix.map(_ + (line + 1)).getOrElse("") //TASTY enumerates lines from 0
         )
         case other => None
-    }
+    }

scala3doc/src/main/scala/dotty/dokka/translators/FilterAttributes.scala

@@ -27,14 +27,14 @@ object FilterAttributes:
   private def keywords(documentable: Documentable): Map[String, String] = documentable match 
     case v: Member =>
       Map("keywords" -> v.modifiers.map(_.name).mkString(","))  
-    case _ =>
+    case null =>
       Map.empty
 
 
   private def visibity(documentable: Documentable): Map[String, String] = documentable match
     case v: Member => 
       Map("visibility" -> v.visibility.name)
-    case _ => 
+    case null => 
       Map.empty
 
 
@@ -45,7 +45,7 @@ object FilterAttributes:
         case Origin.ImplicitlyAddedBy(name, _) => Map("implicitly" -> s"by $name")
         case Origin.ExtensionFrom(name, _) => Map("extension" -> s"from $name")
         case _ => Map.empty
-    case _ =>
+    case null =>
       Map.empty     
 
   def defaultValues = Map(

scala3doc/src/main/scala/dotty/dokka/translators/ScalaPageCreator.scala

@@ -319,7 +319,7 @@ class ScalaPageCreator(
                     }
 
                     d match{
-                        case d: (WithSources & WithExtraProperties[Documentable]) if d.get(SourceLinks) != null && !d.get(SourceLinks).links.isEmpty => d.get(SourceLinks).links.foldLeft(withCompanion){
+                        case d: (WithSources & WithExtraProperties[_]) if d.get(SourceLinks) != null && !d.get(SourceLinks).links.isEmpty => d.get(SourceLinks).links.foldLeft(withCompanion){
                             case (bdr, (sourceSet, link)) => bdr
                                     .cell(sourceSets = Set(sourceSet)){ b => b
                                         .text("Source")
@@ -336,9 +336,11 @@ class ScalaPageCreator(
 
         def contentForScope(s: Documentable & WithScope & WithExtraProperties[_]) = 
             def groupExtensions(extensions: Seq[Member]): Seq[DocumentableSubGroup] = 
-                extensions.groupBy(_.kind).map { case (Kind.Extension(on), members) => 
-                    val signature = Signature(s"extension (${on.name}: ") join on.signature join Signature(")")
-                    DocumentableSubGroup(signature, members.toSeq)
+                extensions.groupBy(_.kind).map {
+                    case (Kind.Extension(on), members) =>
+                        val signature = Signature(s"extension (${on.name}: ") join on.signature join Signature(")")
+                        DocumentableSubGroup(signature, members.toSeq)
+                    case other => sys.error(s"unexpected value: $other")
                 }.toSeq
 
 

scala3doc/src/main/scala/dotty/dokka/translators/ScalaSignatureUtils.scala

@@ -37,7 +37,7 @@ trait SignatureBuilder extends ScalaSignatureUtils {
             elemOp: (SignatureBuilder, E) => SignatureBuilder
         ): SignatureBuilder = elements match {
             case Nil => this
-            case head +: tail =>
+            case head :: tail =>
                 tail.foldLeft(elemOp(text(prefix), head))((b, e) => elemOp(b.text(separator), e)).text(suffix)
         }
 
@@ -118,4 +118,4 @@ trait SignatureBuilder extends ScalaSignatureUtils {
 
 trait ScalaSignatureUtils:
     extension (tokens: Seq[String]) def toSignatureString(): String =
-        tokens.filter(_.trim.nonEmpty).mkString(""," "," ")
+        tokens.filter(_.trim.nonEmpty).mkString(""," "," ")

scala3doc/src/main/scala/dotty/renderers/DotDiagramBuilder.scala

@@ -33,6 +33,7 @@ object DotDiagramBuilder:
         case Kind.Trait => "fill: #1CAACF;"
         case Kind.Enum => "fill: #B66722;"
         case Kind.EnumCase => "fill: #B66722;"
+        case other => sys.error(s"unexpected value: $other")
 
 
     private def getHtmlLabel(vertex: Vertex, renderer: SignatureRenderer): String =

scala3doc/src/test/scala/dotty/dokka/DottyTestRunner.scala

@@ -56,7 +56,7 @@ abstract class DottyAbstractCoreTest extends AbstractCoreTest:
 
         def listTastyFiles(f: File): Seq[File] = 
             val (files, dirs) = f.listFiles().partition(_.isFile)
-            files.filter(_.getName.endsWith(".tasty")) ++ dirs.flatMap(listTastyFiles)
+            files.toIndexedSeq.filter(_.getName.endsWith(".tasty")) ++ dirs.flatMap(listTastyFiles)
 
         val tastyFiles = tastyDir.split(File.pathSeparatorChar).toList.flatMap(p => listTastyFiles(new File(p))).map(_.toString)