implicit objects have correct props

Author: bishabosha

compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala

@@ -342,6 +342,8 @@ class ExtractSemanticDB extends Phase with
         SymbolInformation.Kind.UNKNOWN_KIND
 
     private def symbolProps(sym: Symbol, symkinds: Set[SymbolKind])(given Context): Int =
+      if sym.is(ModuleClass)
+        return symbolProps(sym.sourceModule, symkinds)
       var props = 0
       if sym.isPrimaryConstructor
         props |= SymbolInformation.Property.PRIMARY.value
@@ -353,9 +355,9 @@ class ExtractSemanticDB extends Phase with
         props |= SymbolInformation.Property.SEALED.value
       if sym.isOneOf(GivenOrImplicit)
         props |= SymbolInformation.Property.IMPLICIT.value
-      if sym.is(Lazy)
+      if sym.is(Lazy, butNot=Module)
         props |= SymbolInformation.Property.LAZY.value
-      if sym.isAllOf(CaseClass) || sym.isAllOf(EnumCase)
+      if sym.isAllOf(Case | Module) || sym.is(CaseClass) || sym.isAllOf(EnumCase)
         props |= SymbolInformation.Property.CASE.value
       if sym.is(Covariant)
         props |= SymbolInformation.Property.COVARIANT.value

tests/semanticdb/metac.expect

@@ -1289,19 +1289,19 @@ a/b/Givens.Monoid#empty(). => abstract method empty
 a/b/Givens.foo(). => method foo
 a/b/Givens.foo().(A) => implicit param A
 a/b/Givens.foo().[A] => typeparam A
-a/b/Givens.given_Monoid_String. => final object given_Monoid_String
+a/b/Givens.given_Monoid_String. => final implicit object given_Monoid_String
 a/b/Givens.given_Monoid_String.combine(). => method combine
 a/b/Givens.given_Monoid_String.combine().(x) => param x
 a/b/Givens.given_Monoid_String.combine().(y) => param y
 a/b/Givens.given_Monoid_String.empty(). => method empty
-a/b/Givens.given_sayGoodbye_of_B. => final object given_sayGoodbye_of_B
+a/b/Givens.given_sayGoodbye_of_B. => final implicit object given_sayGoodbye_of_B
 a/b/Givens.given_sayGoodbye_of_B.sayGoodbye(). => method sayGoodbye
 a/b/Givens.given_sayGoodbye_of_B.sayGoodbye().(any) => param any
 a/b/Givens.given_sayGoodbye_of_B.sayGoodbye().[B] => typeparam B
 a/b/Givens.given_sayGoodbye_of_B.saySoLong(). => method saySoLong
 a/b/Givens.given_sayGoodbye_of_B.saySoLong().(any) => param any
 a/b/Givens.given_sayGoodbye_of_B.saySoLong().[B] => typeparam B
-a/b/Givens.given_sayHello_of_A. => final object given_sayHello_of_A
+a/b/Givens.given_sayHello_of_A. => final implicit object given_sayHello_of_A
 a/b/Givens.given_sayHello_of_A.sayHello(). => method sayHello
 a/b/Givens.given_sayHello_of_A.sayHello().(any) => param any
 a/b/Givens.given_sayHello_of_A.sayHello().[A] => typeparam A