Fix #3246: Refine handling of postfix _ for non-functions

Author: odersky

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -1548,17 +1548,19 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
   def typedAsFunction(tree: untpd.PostfixOp, pt: Type)(implicit ctx: Context): Tree = {
     val untpd.PostfixOp(qual, Ident(nme.WILDCARD)) = tree
     val pt1 = if (defn.isFunctionType(pt)) pt else AnyFunctionProto
-    var res = typed(qual, pt1)
-    if (pt1.eq(AnyFunctionProto) && !defn.isFunctionClass(res.tpe.classSymbol)) {
+    val nestedCtx = ctx.fresh.setNewTyperState()
+    var res = typed(qual, pt1)(nestedCtx)
+    if (!defn.isFunctionClass(res.tpe.classSymbol)) {
       ctx.errorOrMigrationWarning(OnlyFunctionsCanBeFollowedByUnderscore(res.tpe), tree.pos)
       if (ctx.scala2Mode) {
         // Under -rewrite, patch `x _` to `(() => x)`
         patch(Position(tree.pos.start), "(() => ")
         patch(Position(qual.pos.end, tree.pos.end), ")")
-        res = typed(untpd.Function(Nil, untpd.TypedSplice(res)))
+        return typed(untpd.Function(Nil, res))
       }
     }
-    else if (ctx.settings.strict.value) {
+    nestedCtx.typerState.commit()
+    if (ctx.settings.strict.value) {
       lazy val (prefix, suffix) = res match {
         case Block(mdef @ DefDef(_, _, vparams :: Nil, _, _) :: Nil, _: Closure) =>
           val arity = vparams.length

tests/pos-scala2/i3246.scala

@@ -0,0 +1,7 @@
+class Test {
+  def foo(x: => Int) = bar(x _)
+  def bar(x: () => Int) = ???
+  def baz = 1
+  def bam: () => Int = baz _
+  def ban: () => Int = 1 _
+}