Merge pull request #12435 from dotty-staging/fix-12430

Disallow attempts to instantiate packages

Author: nicolasstucki

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -778,6 +778,9 @@ class Typer extends Namer
         typed(cpy.Block(tree)(clsDef :: Nil, New(Ident(x), Nil)), pt)
       case _ =>
         var tpt1 = typedType(tree.tpt)
+        val tsym = tpt1.tpe.underlyingClassRef(refinementOK = false).typeSymbol
+        if tsym.is(Package) then
+          report error(em"$tsym cannot be instantiated", tpt1.srcPos)
         tpt1 = tpt1.withType(ensureAccessible(tpt1.tpe, superAccess = false, tpt1.srcPos))
         tpt1 match {
           case AppliedTypeTree(_, targs) =>

tests/neg/i12430.scala

@@ -0,0 +1,4 @@
+class i0 {
+  new collection // error
+  new io // error
+}