Merge pull request #7779 from dotty-staging/fix-#7716

Fix #7716: Always take prefix into account

Author: nicolasstucki

compiler/src/dotty/tools/dotc/ast/tpd.scala

@@ -1261,7 +1261,7 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo {
   def sourceFile(call: Tree)(implicit ctx: Context): SourceFile = call.symbol.source
 
   /** Desugar identifier into a select node. Return the tree itself if not possible */
-  def desugarIdent(tree: Ident)(implicit ctx: Context): Tree = {
+  def desugarIdent(tree: Ident)(implicit ctx: Context): RefTree = {
     val qual = desugarIdentPrefix(tree)
     if (qual.isEmpty) tree
     else qual.select(tree.symbol)

compiler/src/dotty/tools/dotc/transform/Splicer.scala

@@ -495,7 +495,8 @@ object Splicer {
       def unapply(arg: Tree)(implicit ctx: Context): Option[(RefTree, List[List[Tree]])] = arg match {
         case Select(Call0(fn, args), nme.apply) if defn.isContextFunctionType(fn.tpe.widenDealias.finalResultType) =>
           Some((fn, args))
-        case fn: RefTree => Some((fn, Nil))
+        case fn: Ident => Some((tpd.desugarIdent(fn).withSpan(fn.span), Nil))
+        case fn: Select => Some((fn, Nil))
         case Apply(f @ Call0(fn, args1), args2) =>
           if (f.tpe.widenDealias.isErasedMethod) Some((fn, args1))
           else Some((fn, args2 :: args1))

tests/run-macros/i7716.check

@@ -0,0 +1,3 @@
+Hello 1
+Hello 2
+Hello 3

tests/run-macros/i7716/Macro_1.scala

@@ -0,0 +1,17 @@
+import scala.quoted._
+
+trait Foo:
+  def mcrImpl1(e: Expr[Any])(using ctx: QuoteContext): Expr[Any] =
+    '{println(s"Hello ${$e}")}
+
+object Foo extends Foo:
+  def mcrImpl2(e: Expr[Any])(using ctx: QuoteContext): Expr[Any] =
+    '{println(s"Hello ${$e}")}
+
+object Bar:
+  import Foo._
+  inline def mcr1(e: => Any) = ${mcrImpl1('e)}
+
+  inline def mcr2(e: => Any) = ${Foo.mcrImpl1('e)}
+
+  inline def mcr3(e: => Any) = ${mcrImpl2('e)}

tests/run-macros/i7716/Test_2.scala

@@ -0,0 +1,5 @@
+object Test extends App {
+  Bar.mcr1(1)
+  Bar.mcr2(2)
+  Bar.mcr3(3)
+}