Merge pull request #6880 from dotty-staging/do-not-addapt-contextual-closures-while-inlining

Fix #6862, fix #6863: Do not adapt contextual closures while inlining

Author: odersky

compiler/src/dotty/tools/dotc/typer/Inliner.scala

@@ -573,7 +573,7 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(implicit ctx: Context) {
     /** An extractor for terms equivalent to `new C(args)`, returning the class `C`,
      *  a list of bindings, and the arguments `args`. Can see inside blocks and Inlined nodes and can
      *  follow a reference to an inline value binding to its right hand side.
- *
+     *
      *  @return    optionally, a triple consisting of
      *             - the class `C`
      *             - the arguments `args`

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -2048,7 +2048,8 @@ class Typer extends Namer
             xtree.isTerm &&
             !untpd.isContextualClosure(xtree) &&
             !ctx.mode.is(Mode.Pattern) &&
-            !ctx.isAfterTyper)
+            !ctx.isAfterTyper &&
+            !ctx.isInlineContext)
           makeContextualFunction(xtree, ifpt)
         else xtree match {
           case xtree: untpd.NameTree => typedNamed(xtree, pt)
@@ -2660,7 +2661,8 @@ class Typer extends Namer
           !isApplyProto(pt) &&
           pt != AssignProto &&
           !ctx.mode.is(Mode.Pattern) &&
-          !ctx.isAfterTyper) {
+          !ctx.isAfterTyper &&
+          !ctx.isInlineContext) {
         typr.println(i"insert apply on implicit $tree")
         typed(untpd.Select(untpd.TypedSplice(tree), nme.apply), pt, locked)
       }

tests/pos/i6862/lib_1.scala

@@ -0,0 +1,3 @@
+trait Ctx
+inline def foo(): Unit = given (x: Ctx) => ()
+def bar[T](b: given Ctx => Unit): Unit = ???

tests/pos/i6862/test_1.scala

@@ -0,0 +1,3 @@
+class Test {
+  foo()
+}

tests/pos/i6862b/lib.scala

@@ -0,0 +1,8 @@
+
+trait Expr[+T]
+
+trait Ctx
+
+inline def foo(): Int = splice( bar() )
+def bar() given Ctx: Expr[Int] = ???
+def splice[T](f: given Ctx => Expr[T]): T = ???

tests/pos/i6862b/test.scala

@@ -0,0 +1,4 @@
+
+class Test {
+  foo()
+}

tests/pos/i6863/lib_1.scala

@@ -0,0 +1,2 @@
+trait Ctx
+inline def foo(): Unit = given (x: Ctx) => ()

tests/pos/i6863/test_1.scala

@@ -0,0 +1,3 @@
+class Test {
+  foo()
+}