address comments

move the responsibility of closing the inline loop
to apiAnnotations, which hashes the inline body
annotation.

Also add a test for changing second parameter list of
extension methods.

Author: bishabosha

compiler/src/dotty/tools/dotc/sbt/ExtractAPI.scala

@@ -7,9 +7,7 @@ import dotty.tools.dotc.core.Names.Name
 
 inline val TermNameHash = 1987 // 300th prime
 inline val TypeNameHash = 1993 // 301st prime
-inline val EmptyParamHash = 1997 // 302nd prime
-inline val InlineParamHash = 1999 // 303rd prime
-inline val InlineValHash = 2003 // 304th prime
+inline val InlineParamHash = 1997 // 302nd prime
 
 extension (sym: Symbol)
 

compiler/src/dotty/tools/dotc/sbt/package.scala

@@ -0,0 +1,7 @@
+object A {
+
+  class Box[T](val value: T)
+
+  extension (box: Box[Int]) def map[I <: Int](f: Int => I): Box[I] = new Box(f(box.value))
+
+}

sbt-test/source-dependencies/extension-change-second-tparams/A.scala

@@ -0,0 +1,6 @@
+import A.Box
+import A.map
+
+class B {
+  val n = Box(5).map(x => x * 3)
+}

sbt-test/source-dependencies/extension-change-second-tparams/B.scala

@@ -0,0 +1,25 @@
+import sbt.internal.inc.Analysis
+import complete.DefaultParsers._
+
+// Reset compiler iterations, necessary because tests run in batch mode
+val recordPreviousIterations = taskKey[Unit]("Record previous iterations.")
+recordPreviousIterations := {
+  val log = streams.value.log
+  CompileState.previousIterations = {
+    val previousAnalysis = (previousCompile in Compile).value.analysis.asScala
+    previousAnalysis match {
+      case None =>
+        log.info("No previous analysis detected")
+        0
+      case Some(a: Analysis) => a.compilations.allCompilations.size
+    }
+  }
+}
+
+val checkIterations = inputKey[Unit]("Verifies the accumulated number of iterations of incremental compilation.")
+
+checkIterations := {
+  val expected: Int = (Space ~> NatBasic).parsed
+  val actual: Int = ((compile in Compile).value match { case a: Analysis => a.compilations.allCompilations.size }) - CompileState.previousIterations
+  assert(expected == actual, s"Expected $expected compilations, got $actual")
+}

sbt-test/source-dependencies/extension-change-second-tparams/build.sbt

@@ -0,0 +1,7 @@
+object A {
+
+  class Box[T](val value: T)
+
+  extension (box: Box[Int]) def map[I](f: Int => I): Box[I] = new Box(f(box.value))
+
+}

sbt-test/source-dependencies/extension-change-second-tparams/changes/A1.scala

@@ -0,0 +1,4 @@
+// This is necessary because tests are run in batch mode
+object CompileState {
+  @volatile var previousIterations: Int = -1
+}

sbt-test/source-dependencies/extension-change-second-tparams/project/CompileState.scala

@@ -0,0 +1,11 @@
+import sbt._
+import Keys._
+
+object DottyInjectedPlugin extends AutoPlugin {
+  override def requires = plugins.JvmPlugin
+  override def trigger = allRequirements
+
+  override val projectSettings = Seq(
+    scalaVersion := sys.props("plugin.scalaVersion")
+  )
+}

sbt-test/source-dependencies/extension-change-second-tparams/project/DottyInjectedPlugin.scala

@@ -0,0 +1,7 @@
+> compile
+> recordPreviousIterations
+# Force recompilation of B because A.map, called by B.n, has changed
+$ copy-file changes/A1.scala A.scala
+> compile
+# 1 to recompile A, then 1 more to recompile B due to A.map change
+> checkIterations 2