Mark inactive error codes found when documenting, remove dead code from messages.scala

Author: WojciechMazur

compiler/src/dotty/tools/dotc/reporting/ErrorMessageID.scala

@@ -98,7 +98,7 @@ enum ErrorMessageID(val isActive: Boolean = true) extends java.lang.Enum[ErrorMe
   case SuperCallsNotAllowedInlineableID // errorNumber: 82
   case NotAPathID // errorNumber: 83
   case WildcardOnTypeArgumentNotAllowedOnNewID // errorNumber: 84
-  case FunctionTypeNeedsNonEmptyParameterListID // errorNumber: 85
+  case FunctionTypeNeedsNonEmptyParameterListID extends ErrorMessageID(isActive = false) // errorNumber: 85
   case WrongNumberOfParametersID // errorNumber: 86
   case DuplicatePrivateProtectedQualifierID // errorNumber: 87
   case ExpectedStartOfTopLevelDefinitionID // errorNumber: 88
@@ -107,7 +107,7 @@ enum ErrorMessageID(val isActive: Boolean = true) extends java.lang.Enum[ErrorMe
   case ReturnOutsideMethodDefinitionID // errorNumber: 91
   case UncheckedTypePatternID // errorNumber: 92
   case ExtendFinalClassID // errorNumber: 93
-  case EnumCaseDefinitionInNonEnumOwnerID // errorNumber: 94
+  case EnumCaseDefinitionInNonEnumOwnerID extends ErrorMessageID(isActive = false) // errorNumber: 94
   case ExpectedTypeBoundOrEqualsID // errorNumber: 95
   case ClassAndCompanionNameClashID // errorNumber: 96
   case TailrecNotApplicableID // errorNumber: 97
@@ -118,15 +118,15 @@ enum ErrorMessageID(val isActive: Boolean = true) extends java.lang.Enum[ErrorMe
   case UndefinedNamedTypeParameterID // errorNumber: 102
   case IllegalStartOfStatementID // errorNumber: 1033
   case TraitIsExpectedID // errorNumber: 104
-  case TraitRedefinedFinalMethodFromAnyRefID // errorNumber: 105
+  case TraitRedefinedFinalMethodFromAnyRefID extends ErrorMessageID(isActive = false) // errorNumber: 105
   case PackageNameAlreadyDefinedID // errorNumber: 106
   case UnapplyInvalidNumberOfArgumentsID // errorNumber: 107
   case UnapplyInvalidReturnTypeID // errorNumber: 108
   case StaticFieldsOnlyAllowedInObjectsID // errorNumber: 109
   case CyclicInheritanceID // errorNumber: 110
   case BadSymbolicReferenceID // errorNumber: 111
   case UnableToExtendSealedClassID // errorNumber: 112
-  case SymbolHasUnparsableVersionNumberID // errorNumber: 113
+  case SymbolHasUnparsableVersionNumberID // errorNumber: 113 
   case SymbolChangedSemanticsInVersionID // errorNumber: 114
   case UnableToEmitSwitchID // errorNumber: 115
   case MissingCompanionForStaticID // errorNumber: 116
@@ -163,9 +163,9 @@ enum ErrorMessageID(val isActive: Boolean = true) extends java.lang.Enum[ErrorMe
   case RedundantModifierID // errorNumber: 147
   case TypedCaseDoesNotExplicitlyExtendTypedEnumID // errorNumber: 148
   case IllegalRedefinitionOfStandardKindID // errorNumber: 149
-  case NoExtensionMethodAllowedID // errorNumber: 150
-  case ExtensionMethodCannotHaveTypeParamsID // errorNumber: 151
-  case ExtensionCanOnlyHaveDefsID // errorNumber: 152
+  case NoExtensionMethodAllowedID extends ErrorMessageID(isActive = false) // errorNumber: 150
+  case ExtensionMethodCannotHaveTypeParamsID extends ErrorMessageID(isActive = false) // errorNumber: 151
+  case ExtensionCanOnlyHaveDefsID extends ErrorMessageID(isActive = false) // errorNumber: 152
   case UnexpectedPatternForSummonFromID // errorNumber: 153
   case AnonymousInstanceCannotBeEmptyID // errorNumber: 154
   case TypeSpliceInValPatternID extends ErrorMessageID(isActive = false) // errorNumber: 155
@@ -209,7 +209,7 @@ enum ErrorMessageID(val isActive: Boolean = true) extends java.lang.Enum[ErrorMe
   case VolatileOnValID // errorNumber: 193
   case ExtensionNullifiedByMemberID // errorNumber: 194
   case PhantomSymbolNotValueID // errorNumber: 195
-  case ContextBoundCompanionNotValueID // errorNumber: 196
+  case ContextBoundCompanionNotValueID extends ErrorMessageID(isActive = false) // errorNumber: 196
   case InlinedAnonClassWarningID // errorNumber: 197
   case UnusedSymbolID // errorNumber: 198
   case TailrecNestedCallID //errorNumber: 199

compiler/src/dotty/tools/dotc/reporting/messages.scala

@@ -2108,11 +2108,6 @@ class TraitIsExpected(symbol: Symbol)(using Context) extends SyntaxMsg(TraitIsEx
   }
 }
 
-class TraitRedefinedFinalMethodFromAnyRef(method: Symbol)(using Context) extends SyntaxMsg(TraitRedefinedFinalMethodFromAnyRefID) {
-  def msg(using Context) = i"Traits cannot redefine final $method from ${hl("class AnyRef")}."
-  def explain(using Context) = ""
-}
-
 class AlreadyDefined(name: Name, owner: Symbol, conflicting: Symbol)(using Context)
 extends NamingMsg(AlreadyDefinedID):
   def msg(using Context) =
@@ -2823,29 +2818,6 @@ class IllegalRedefinitionOfStandardKind(kindType: String, name: Name)(using Cont
         | Please choose a different name to avoid conflicts
         |"""
 }
-
-class NoExtensionMethodAllowed(mdef: untpd.DefDef)(using Context)
-  extends SyntaxMsg(NoExtensionMethodAllowedID) {
-  def msg(using Context) = i"No extension method allowed here, since collective parameters are given"
-  def explain(using Context) =
-    i"""|Extension method:
-        |  `${mdef}`
-        |is defined inside an extension clause which has collective parameters.
-        |"""
-}
-
-class ExtensionMethodCannotHaveTypeParams(mdef: untpd.DefDef)(using Context)
-  extends SyntaxMsg(ExtensionMethodCannotHaveTypeParamsID) {
-  def msg(using Context) = i"Extension method cannot have type parameters since some were already given previously"
-
-  def explain(using Context) =
-    i"""|Extension method:
-        |  `${mdef}`
-        |has type parameters `[${mdef.leadingTypeParams.map(_.show).mkString(",")}]`, while the extension clause has
-        |it's own type parameters. Please consider moving these to the extension clause's type parameter list.
-        |"""
-}
-
 class ExtensionCanOnlyHaveDefs(mdef: untpd.Tree)(using Context)
   extends SyntaxMsg(ExtensionCanOnlyHaveDefsID) {
   def msg(using Context) = i"Only methods allowed here, since collective parameters are given"