Skip package objects in Typer#findRef

Author: odersky

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -265,7 +265,12 @@ class Typer extends Namer
           // with the exact list of files given).
           val isNewDefScope =
             if (curOwner.is(Package) && !curOwner.isRoot) curOwner ne ctx.outer.owner
-            else (ctx.scope ne lastCtx.scope) || (curOwner ne lastCtx.owner)
+            else ((ctx.scope ne lastCtx.scope) || (curOwner ne lastCtx.owner)) &&
+              !curOwner.isPackageObject
+              // Package objects are never searched directly. We wait until we
+              // hit the enclosing package. That way we make sure we consider
+              // all overloaded altrenatives of a definition, even if they are
+              // in different source files.
 
           if (isNewDefScope) {
             val defDenot = ctx.denotNamed(name, required)

tests/run/toplevel-overloads/defs_1.scala

@@ -2,11 +2,11 @@ package top
 
 def hello(name: String) = s"hello, $name"
 def hello(x: Int) = x.toString
-def hello(x: Boolean) = if (x) "yes" else "no"
 
 object O {
   def hi = hello("Bob")
   def gb = hello(true)
 }
 
-val test = hello(false)
+val test1 = top.hello(false)
+val test2 = hello(false)

tests/run/toplevel-overloads/moredefs_1.scala

@@ -1,3 +1,4 @@
 package top
 
-def hello(b: Boolean) = b.toString
+def hello(b: Boolean): String = if (b) "yes" else "no"
+