Correctly handle default scalac arguments

Author: romanowski

scala3doc/src/dotty/dokka/Main.scala

@@ -30,7 +30,7 @@ object Main:
   def main(args: Array[String]): Unit =
     try
       // We should create our own context here...
-      val reporter = Scala3doc.run(args)(using (new ContextBase).initialCtx)
+      val reporter = Scala3doc.run(args, (new ContextBase).initialCtx)
       // Sometimes jvm is hanging, so we want to be sure that we force shout down the jvm
       sys.exit(if reporter.hasErrors then 1 else 0)
     catch

scala3doc/src/dotty/dokka/Scala3doc.scala

@@ -67,8 +67,9 @@ object Scala3doc:
     revision: Option[String] = None
   )
 
-  def run(args: Array[String])(using ctx: CompilerContext): Reporter =
-    val parsedArgs = Scala3docArgs.extract(args.toList)
+  def run(args: Array[String], rootContext: CompilerContext): Reporter =
+    val (parsedArgs, ctx) = Scala3docArgs.extract(args.toList, rootContext)
+    given CompilerContext = ctx
 
     def listTastyFiles(f: File): Seq[File] =
       val (files, dirs) = Option(f.listFiles()).toArray.flatten.partition(_.isFile)

scala3doc/src/dotty/dokka/Scala3docArgs.scala

@@ -34,17 +34,17 @@ class Scala3docArgs extends SettingGroup with CommonScalaSettings:
   val revision: Setting[String] =
     StringSetting("-revision", "revision", "Revision (branch or ref) used to build project project", "")
 
+  def scala3docSpecificSettings: Set[Setting[_]] = Set(sourceLinks, syntax, revision)
+
 object Scala3docArgs:
-  def extract(args: List[String])(using CompilerContext) =
+  def extract(args: List[String], rootCtx: CompilerContext):(Scala3doc.Args, CompilerContext) =
     val inst = new Scala3docArgs
     import inst._
     val initialSummary =
       ArgsSummary(defaultState, args, errors = Nil, warnings = Nil)
     val summary =
       processArguments(initialSummary, processAll = true, skipped = Nil)
-
-    summary.warnings.foreach(report.warning(_))
-    summary.errors.foreach(report.error(_))
+    val newContext = rootCtx.fresh
 
     extension[T](arg: Setting[T]):
       def get = arg.valueIn(summary.sstate)
@@ -53,6 +53,19 @@ object Scala3docArgs:
       def nonDefault =
         if arg.get == arg.default then None else Some(arg.get)
 
+    def setInGlobal[T](s: Setting[T]) =
+      s.nonDefault.foreach { newValue =>
+        newContext.settings.allSettings.find(_ == s).fold(
+          report.warning(s"Unable to set ${s.name} in global context")
+        )(s => newContext.setSetting(s.asInstanceOf[Setting[T]], newValue))
+      }
+
+    allSettings.filterNot(scala3docSpecificSettings.contains).foreach(setInGlobal)
+
+    given CompilerContext = newContext
+    summary.warnings.foreach(report.warning(_))
+    summary.errors.foreach(report.error(_))
+
     def parseTastyRoots(roots: String) =
       roots.split(File.pathSeparatorChar).toList.map(new File(_))
 
@@ -91,7 +104,7 @@ object Scala3docArgs:
     report.inform(
       s"Generating documenation $printableProjectName in $destFile")
 
-    Args(
+    val docArgs = Args(
       projectName.withDefault("root"),
       dirs,
       validFiles,
@@ -103,4 +116,5 @@ object Scala3docArgs:
       parseSyntax,
       sourceLinks.nonDefault.fold(Nil)(_.split(",").toList),
       revision.nonDefault
-    )
+    )
+    (docArgs, newContext)

…/dotty/dokka/site/NaivationCreator.scala …dotty/dokka/site/NavigationCreator.scalascala3doc/src/dotty/dokka/site/NaivationCreator.scala renamed to scala3doc/src/dotty/dokka/site/NavigationCreator.scala scala3doc/src/dotty/dokka/site/NaivationCreator.scala renamed to scala3doc/src/dotty/dokka/site/NavigationCreator.scala

@@ -107,18 +107,18 @@ case class TastyParser(qctx: Quotes, inspector: DokkaTastyInspector)(using val c
 
   def processTree[T](tree: Tree)(op: => T): Option[T] = try Option(op) catch
     case e: Exception  =>
-      report.error(throwableToString(e), tree.pos)
+      report.warning(throwableToString(e), tree.pos)
       None
   def processTreeOpt[T](tree: Tree)(op: => Option[T]): Option[T] = try op catch
     case e: Exception =>
-      report.error(throwableToString(e), tree.pos)
+      report.warning(throwableToString(e), tree.pos)
       None
 
   def processSymbol[T](sym: Symbol)(op: => T): Option[T] = try Option(op) catch
     case t: Throwable =>
-      try report.error(throwableToString(t), sym.tree.pos) catch
+      try report.warning(throwableToString(t), sym.tree.pos) catch
         case _: Throwable =>
-          report.error(s"Failed to process ${sym.show}:\n${throwableToString(t)}")
+          report.warning(s"Failed to process ${sym.show}:\n${throwableToString(t)}")
       None
 
   def parseRootTree(root: Tree): Seq[Documentable] =

scala3doc/src/dotty/dokka/tasty/TastyParser.scala

@@ -265,7 +265,7 @@ class ScalaHtmlRenderer(using ctx: DokkaContext) extends HtmlRenderer(ctx) {
             .flatMap(dri => Option(getLocationProvider.resolve(dri, sourceSets, page)))
             .map(_ + prefix)
             .getOrElse {
-              println(s"[WARN] ${prc.template.file}: Unable to resolve link '$str'")
+              report.warn(s"Unable to resolve link '$str'", prc.template.file)
               str
             }
 

scala3doc/src/dotty/renderers/ScalaHtmlRenderer.scala

@@ -22,4 +22,4 @@ object Main extends Driver:
     * how they're split).
     */
   override def process(args: Array[String], rootCtx: Context): Reporter =
-    dotty.dokka.Scala3doc.run(args)(using rootCtx)
+    dotty.dokka.Scala3doc.run(args, rootCtx)