Fix handling of the external links in Scaladoc

This includes both fixing links found in searchbar, and ones accessible
from method names. In searchbar, links are resolved based on whether
they are absolute (pointing to an external website, like java docs) or
relative (pointing to another sub-website, with root being appended on
runtime). This is achieved by serializing another boolean field in
PageEntry.

Author: jchyb

scaladoc-js/main/src/searchbar/PageEntry.scala

@@ -4,17 +4,19 @@ import scala.scalajs.js
 
 @js.native
 trait PageEntryJS extends js.Object {
-  val n: String = js.native
-  val t: String = js.native
-  val d: String = js.native
-  val l: String = js.native
-  val k: String = js.native
+  val n: String  = js.native
+  val t: String  = js.native
+  val d: String  = js.native
+  val l: String  = js.native
+  val e: Boolean = js.native
+  val k: String  = js.native
 }
 
 case class PageEntry(
   fullName: String,
   description: String,
   location: String,
+  isLocationExternal: Boolean,
   shortName: String,
   kind: String,
   tokens: List[String]
@@ -34,6 +36,7 @@ object PageEntry {
       jsObj.t,
       jsObj.d,
       jsObj.l,
+      jsObj.e,
       jsObj.n.toLowerCase,
       jsObj.k,
       StringUtils.createCamelCaseTokens(jsObj.n)

scaladoc-js/main/src/searchbar/SearchbarComponent.scala

@@ -22,7 +22,12 @@ class SearchbarComponent(engine: SearchbarEngine, inkuireEngine: InkuireJSSearch
       icon.classList.add(p.kind.take(2))
 
       val resultA = document.createElement("a").asInstanceOf[html.Anchor]
-      resultA.href = Globals.pathToRoot + p.location
+      resultA.href =
+        if (p.isLocationExternal) {
+          p.location
+        } else {
+          Globals.pathToRoot + p.location
+        }
       resultA.text = s"${p.fullName}"
       resultA.onclick = (event: Event) =>
         if (document.body.contains(rootDiv)) {

scaladoc-js/main/test/dotty/tools/scaladoc/MatchersTest.scala

@@ -34,6 +34,7 @@ class MatchersTest:
     s"$kind $name",
     "",
     "",
+    false,
     s"$name",
     kind,
     StringUtils.createCamelCaseTokens(name)

scaladoc/src/dotty/tools/scaladoc/renderers/Locations.scala

@@ -85,6 +85,9 @@ trait Locations(using ctx: DocContext):
   def escapedAbsolutePathWithAnchor(dri: DRI, extension: String = "html"): String =
     s"${escapeUrl(absolutePath(dri, extension))}#${dri.anchor}"
 
+  def relativeInternalOrAbsoluteExternalPath(dri: DRI): String =
+    dri.externalLink.getOrElse(escapedAbsolutePathWithAnchor(dri))
+
   def resolveLink(dri: DRI, url: String): String =
     if URI(url).isAbsolute then url else resolveRoot(dri, url)
 

scaladoc/src/dotty/tools/scaladoc/renderers/Renderer.scala

@@ -118,7 +118,9 @@ abstract class Renderer(rootPackage: Member, val members: Map[DRI, Member], prot
       val signatureRenderer = new SignatureRenderer:
         def currentDri: DRI = page.link.dri
         def link(dri: DRI): Option[String] =
-          Some(pathToPage(currentDri, dri)).filter(_ != UnresolvedLocationLink)
+          dri.externalLink.orElse(
+            Some(pathToPage(currentDri, dri)).filter(_ != UnresolvedLocationLink)
+          )
 
       MemberRenderer(signatureRenderer).fullMember(m)
     case t: ResolvedTemplate => siteContent(page.link.dri, t)

scaladoc/src/dotty/tools/scaladoc/renderers/Resources.scala

@@ -133,7 +133,8 @@ trait Resources(using ctx: DocContext) extends Locations, Writer:
       }.mkString
 
     def mkEntry(dri: DRI, name: String, text: String, descr: String, kind: String) = jsonObject(
-        "l" -> jsonString(escapedAbsolutePathWithAnchor(dri)),
+        "l" -> jsonString(relativeInternalOrAbsoluteExternalPath(dri)),
+        "e" -> (if dri.externalLink.isDefined then rawJSON("true") else rawJSON("false")),
         "n" -> jsonString(name),
         "t" -> jsonString(text),
         "d" -> jsonString(descr),