Revert: Instrumentation to get basedata computation counts

(reverted from commit c1254ed)

Last data over whole legacy test suite (running time: 337s):

BaseData cache fills per phase:

  0, 670675, 0, 0, 2648, 0, 12, 0, 2, 548, 1153, 1189, 190, 115, 0, 0, 0, 0, 28, 68, 0, 0, 129, 267, 0, 0, 0, 0, 0, 4, 0, 38, 0, 3, 13, 1, 6857, 809, 167147, 59961, 671, 246, 5417, 169, 114, 615, 17, 0, 2, 0, 1753, 0, 27, 0, 0, 8032, 26338, 0, 0, 736, 0, 0, 0, 4851, 69224, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0

Cache invalidations: 80

Author: odersky

compiler/src/dotty/tools/dotc/Run.scala

@@ -92,8 +92,6 @@ class Run(comp: Compiler)(implicit ctx: Context) {
     for (unit <- units)
       Stats.record("retained typed trees at end", unit.tpdTree.treeSize)
     Stats.record("total trees at end", ast.Trees.ntrees)
-    println(s"bts counts: ${SymDenotations.btsCount.deep}")
-    println(s"invalidate count: ${SymDenotations.invalidateCount}")
   }
 
   private sealed trait PrintedTree

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -1421,7 +1421,6 @@ object SymDenotations {
       }
       def emptyParentsExpected =
         is(Package) || (symbol == defn.AnyClass) || ctx.erasedTypes && (symbol == defn.ObjectClass)
-      btsCount(ctx.phaseId) += 1
       if (classParents.isEmpty && !emptyParentsExpected)
         onBehalf.signalProvisional()
       (classSymbol :: addParentBaseClasses(classParents, Nil),
@@ -2041,8 +2040,7 @@ object SymDenotations {
     final def isValid(implicit ctx: Context): Boolean = valid && isValidAt(ctx.phase)
 
     def invalidate(): Unit =
-      if (valid && !locked) {
-        invalidateCount += 1
+      if (isValid && !locked) {
         cache = null
         valid = false
         invalidateDependents()
@@ -2089,7 +2087,4 @@ object SymDenotations {
   }
 
   @sharable private var indent = 0 // for completions printing
-
-  @sharable val btsCount = new Array[Int](Periods.MaxPossiblePhaseId + 1)
-  @sharable var invalidateCount = 0
 }