Drop ResetPrivate flag

Author: odersky

compiler/src/dotty/tools/dotc/cc/Setup.scala

@@ -70,8 +70,8 @@ class Setup extends PreRecheck, SymTransformer, SetupAPI:
     if symd.isAllOf(PrivateParamAccessor)
         && symd.owner.is(CaptureChecked)
         && !symd.hasAnnotation(defn.ConstructorOnlyAnnot)
-        //&& containsCovarRetains(symd.symbol.originDenotation.info)
-    then symd.flags &~ Private | Recheck.ResetPrivate
+        && containsCovarRetains(symd.symbol.originDenotation.info)
+    then symd.flags &~ Private
     else symd.flags
 
   def isPreCC(sym: Symbol)(using Context): Boolean =

compiler/src/dotty/tools/dotc/transform/OverridingPairs.scala

@@ -34,7 +34,9 @@ object OverridingPairs:
      */
     protected def exclude(sym: Symbol): Boolean =
       !sym.memberCanMatchInheritedSymbols
-      || isCaptureChecking && sym.is(Recheck.ResetPrivate)
+      || isCaptureChecking && atPhase(ctx.phase.prev)(sym.is(Private))
+        // for capture checking we drop the private flag of certain parameter accessors
+        // but these still need no overriding checks
 
     /** The parents of base that are checked when deciding whether an overriding
      *  pair has already been treated in a parent class.

compiler/src/dotty/tools/dotc/transform/Recheck.scala

@@ -27,13 +27,6 @@ import annotation.tailrec
 object Recheck:
   import tpd.*
 
-  /** A flag used to indicate that a ParamAccessor has been temporarily made not-private
-   *  Only used at the start of the Recheck phase, reset at its end.
-   *  The flag repurposes the Scala2ModuleVar flag. No confusion is possible since
-   *  Scala2ModuleVar cannot be also ParamAccessors.
-   */
-  val ResetPrivate = Scala2ModuleVar
-
   /** Attachment key for rechecked types of TypeTrees */
   val RecheckedType = Property.Key[Type]