test(pre-commit): shfmt+shellcheck test/fallback/update-fallback-links

Author: scop

.pre-commit-config.yaml

@@ -13,7 +13,7 @@ repos:
     hooks:
       - id: shfmt
         types: [text]
-        files: ^(bash_completion(\.d/[^/]+\.bash)?|completions/.+|test/(config/bashrc|update-test-cmd-list)|.+\.sh(\.in)?)$
+        files: ^(bash_completion(\.d/[^/]+\.bash)?|completions/.+|test/(config/bashrc|fallback/update-fallback-links|update-test-cmd-list)|.+\.sh(\.in)?)$
         exclude: ^completions/(\.gitignore|Makefile.*)$
 
   - repo: https://github.com/shellcheck-py/shellcheck-py
@@ -22,7 +22,7 @@ repos:
       - id: shellcheck
         args: [-f, gcc]
         types: [text]
-        files: ^(bash_completion(\.d/[^/]+\.bash)?|completions/.+|test/(config/bashrc|update-test-cmd-list)|.+\.sh(\.in)?)$
+        files: ^(bash_completion(\.d/[^/]+\.bash)?|completions/.+|test/(config/bashrc|fallback/update-fallback-links|update-test-cmd-list)|.+\.sh(\.in)?)$
         exclude: ^completions/(\.gitignore|Makefile.*)$
         require_serial: false  # We disable SC1090 anyway, so parallel is ok
 

test/fallback/update-fallback-links

@@ -8,13 +8,13 @@ is_tracked_by_git()
 
 cd "$(dirname "$0")/completions"
 for f in *; do
-    if [[ -h $f ]] && is_tracked_by_git "$f"; then
+    if [[ -L $f ]] && is_tracked_by_git "$f"; then
         git rm -f "$f"
     fi
 done
 for f in ../../../completions/_*; do
     if is_tracked_by_git "$f"; then
-        ln -sf $f ${f##*/_}
-        git add --verbose ${f##*/_}
+        ln -sf "$f" "${f##*/_}"
+        git add --verbose "${f##*/_}"
     fi
 done