Commit 8cf1283
build(pkgutil): don't install on non-Solaris platforms
In commit 0e3a17d, a short-circuit was added
that causes the completion to return 1 if the host OS is not solaris.
On Gentoo, this triggers a warning:
```
* QA Notice: Problems with installed bash completions were found:
*
* pkgutil: does not define any completions (failed to source?).
*
* For more details on installing bash-completions, please see:
* https://wiki.gentoo.org/wiki/Bash/Installing_completion_files
```
The purpose of the check is to find broken completions that need to be fixed by
their respective upstreams, and in this case the completion is "intentionally
broken". It seems straightforward to respect that at an earlier level, which
both avoids the QA check and ensures that unneeded files don't get installed on
any distro.
And... it also means that macOS users can ship their own pkgutil completion
without worrying about file clashes with the bash-completion project. The
entire reason for the short-circuit was because there's a *different* pkgutil
there.
Fixes: 0e3a17d1 parent 165bd32 commit 8cf1283
2 files changed
+16
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
328 | 328 | | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
332 | 331 | | |
333 | 332 | | |
334 | 333 | | |
| |||
503 | 502 | | |
504 | 503 | | |
505 | 504 | | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
506 | 510 | | |
507 | 511 | | |
508 | 512 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
14 | 25 | | |
15 | 26 | | |
16 | 27 | | |
| |||
0 commit comments