Fix issue with passing options to new tabs in CDP Mode

Author: mdmintz

seleniumbase/core/sb_cdp.py

@@ -1182,13 +1182,15 @@ def switch_to_window(self, window):
     def switch_to_newest_window(self):
         self.switch_to_tab(-1)
 
-    def open_new_tab(self, url=None, switch_to=True):
+    def open_new_tab(self, url=None, switch_to=True, **kwargs):
         driver = self.driver
         if not isinstance(url, str):
             url = "about:blank"
         if hasattr(driver, "cdp_base"):
             try:
-                self.loop.run_until_complete(self.page.get(url, new_tab=True))
+                self.loop.run_until_complete(
+                    self.page.get(url, new_tab=True, **kwargs)
+                )
             except Exception:
                 original_targets = self.loop.run_until_complete(
                     self.page.send(mycdp.target.get_targets())

seleniumbase/fixtures/base_case.py

@@ -221,11 +221,11 @@ def test_example(self):
                 [sys.executable, "-m", "pytest", file, "-s", *all_args]
             )
 
-    def open(self, url):
+    def open(self, url, **kwargs):
         """Navigates the current browser window to the specified page."""
         self.__check_scope()
         if self.__is_cdp_swap_needed():
-            self.cdp.open(url)
+            self.cdp.open(url, **kwargs)
             return
         elif (
             getattr(self.driver, "_is_using_uc", None)
@@ -235,14 +235,14 @@ def open(self, url):
             # Auth in UC Mode requires CDP Mode
             # (and now we're always forcing it)
             logging.info("open() in UC Mode now always activates CDP Mode.")
-            self.activate_cdp_mode(url)
+            self.activate_cdp_mode(url, **kwargs)
             return
         elif (
             getattr(self.driver, "_is_using_uc", None)
             and getattr(self.driver, "_is_using_cdp", None)
         ):
             self.disconnect()
-            self.cdp.open(url)
+            self.cdp.open(url, **kwargs)
             return
         self._check_browser()
         if self.__needs_minimum_wait():
@@ -3960,7 +3960,7 @@ def set_content_to_parent_frame(self):
         Reverts self.set_content_to_frame()."""
         self.set_content_to_default(nested=True)
 
-    def open_new_window(self, switch_to=True):
+    def open_new_window(self, switch_to=True, **kwargs):
         """Opens a new browser tab/window and switches to it by default."""
         url = None
         if self.__looks_like_a_page_url(str(switch_to)):
@@ -3969,14 +3969,14 @@ def open_new_window(self, switch_to=True):
             url = switch_to
             switch_to = True
         if self.__is_cdp_swap_needed():
-            self.cdp.open_new_tab(url=url, switch_to=switch_to)
+            self.cdp.open_new_tab(url=url, switch_to=switch_to, **kwargs)
             return
         elif (
             getattr(self.driver, "_is_using_uc", None)
             and getattr(self.driver, "_is_using_cdp", None)
         ):
             self.disconnect()
-            self.cdp.open_new_tab(url=url, switch_to=switch_to)
+            self.cdp.open_new_tab(url=url, switch_to=switch_to, **kwargs)
             return
         self.wait_for_ready_state_complete()
         if switch_to:
@@ -9264,9 +9264,9 @@ def reload_page(self):
         """Same as self.refresh_page()"""
         self.refresh_page()
 
-    def open_new_tab(self, switch_to=True):
+    def open_new_tab(self, switch_to=True, **kwargs):
         """Same as self.open_new_window()"""
-        self.open_new_window(switch_to=switch_to)
+        self.open_new_window(switch_to=switch_to, **kwargs)
 
     def switch_to_tab(self, tab, timeout=None):
         """Same as self.switch_to_window()

seleniumbase/undetected/cdp_driver/browser.py

@@ -333,11 +333,16 @@ async def get(
             )
             connection.browser = self
         else:
-            # First tab from browser.tabs
-            connection: tab.Tab = next(
-                filter(lambda item: item.type_ == "page", self.targets)
-            )
-            await connection.sleep(0.005)
+            try:
+                # Most recently opened tab
+                connection = self.targets[-1]
+                await connection.sleep(0.005)
+            except Exception:
+                # First tab from browser.tabs
+                connection: tab.Tab = next(
+                    filter(lambda item: item.type_ == "page", self.targets)
+                )
+                await connection.sleep(0.005)
         _cdp_timezone = None
         _cdp_user_agent = ""
         _cdp_locale = None

seleniumbase/undetected/cdp_driver/tab.py

@@ -371,7 +371,7 @@ async def get(
                 return self
             else:
                 return await self.browser.get(
-                    url, new_tab, new_window, **kwargs
+                    url, new_tab=False, new_window=False, **kwargs
                 )
 
     async def open(self, url="about:blank"):