Address PR review comments

- Update @types/react and @types/react-dom to v19 to match React 19 runtime
- Fix Gemfile regex to handle multi-line gem declarations
- Document why bundle isolation is only needed for minimum version examples
- Improve script/convert fallback logic to handle all file path patterns
  with warning when file not found

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justin808

pnpm-lock.yaml

@@ -166,6 +166,12 @@ end
 #   :rspec_args - additional rspec arguments (default: "")
 #   :env_vars - additional environment variables (default: "")
 #   :unbundled - run with unbundled_sh_in_dir for Bundler isolation (default: false)
+#                This is required for minimum version examples because they have different
+#                gem versions (e.g., Shakapacker 8.2.0) pinned in their Gemfile than the
+#                parent workspace (Shakapacker 9.x). Without bundle isolation, Bundler
+#                would inherit the parent's gem resolution and use the wrong versions.
+#                Latest version examples don't need this because they use the same versions
+#                as the parent workspace.
 def run_tests_in(dir, options = {})
   path = calc_path(dir)
 

react_on_rails/rakelib/run_rspec.rake

@@ -59,8 +59,12 @@ namespace :shakapacker_examples do # rubocop:disable Metrics/BlockLength
     if File.exist?(gemfile_path)
       gemfile_content = File.read(gemfile_path)
       # Replace any shakapacker gem line with exact version pin
+      # Handle both single-line: gem 'shakapacker', '>= 8.2.0'
+      # And multi-line declarations:
+      #   gem 'shakapacker',
+      #       '>= 8.2.0'
       gemfile_content = gemfile_content.gsub(
-        /gem ['"]shakapacker['"].*$/,
+        /gem ['"]shakapacker['"][^\n]*(?:\n\s+[^g\n][^\n]*)*$/m,
         "gem 'shakapacker', '#{ExampleType::MINIMUM_SHAKAPACKER_VERSION}'"
       )
       File.write(gemfile_path, gemfile_content)

react_on_rails/rakelib/shakapacker_examples.rake

@@ -15,9 +15,26 @@ def gsub_file_content(path, old_content, new_content)
   # Support both old structure (files at root) and new structure (files in react_on_rails/)
   # This allows the script to work before and after the monorepo reorganization
   unless File.exist?(path)
-    # Try the old location by removing one level of nesting
-    old_path = path.sub(%r{/react_on_rails/Gemfile}, "/Gemfile")
-    path = old_path if File.exist?(old_path)
+    # Try alternate locations:
+    # 1. For react_on_rails subdirectory paths, try removing that nesting
+    # 2. For packages/* paths, try the old node_package/ location
+    alternate_paths = [
+      path.sub(%r{/react_on_rails/}, "/"),
+      path.sub(%r{/packages/react-on-rails/}, "/node_package/"),
+      path.sub(%r{/packages/react-on-rails-pro/}, "/react_on_rails_pro/node_package/")
+    ]
+
+    alternate_paths.each do |alt_path|
+      if File.exist?(alt_path)
+        path = alt_path
+        break
+      end
+    end
+  end
+
+  unless File.exist?(path)
+    warn "Warning: File not found: #{path}"
+    return
   end
 
   content = File.binread(path)