Tests: simplify the PHPCS setup method [1] (#115)

- Remove the `$sniffFiles` parameter which doesn't change between calls to the method anyway and replace it with a class constant and a call to `realpath()` within the function.
- Remove the `getSniffFiles()` method which is now no longer needed.
- Adjust all calls to the `prepareLocalFileForSniffs()` method to remove the parameter.

Author: jrfnl

VariableAnalysis/Tests/BaseTestCase.php

@@ -7,12 +7,17 @@
 use PHP_CodeSniffer\Config;
 
 class BaseTestCase extends TestCase {
-  public function prepareLocalFileForSniffs($sniffFiles, $fixtureFile) {
-    $config = new Config(['--standard=VariableAnalysis']);
-    $ruleset = new Ruleset($config);
-    if (! is_array($sniffFiles)) {
-      $sniffFiles = [$sniffFiles];
-    }
+  const STANDARD_NAME = 'VariableAnalysis';
+  const SNIFF_FILE = __DIR__ . '/../Sniffs/CodeAnalysis/VariableAnalysisSniff.php';
+
+  public function prepareLocalFileForSniffs($fixtureFile) {
+    $config            = new Config();
+    $config->cache     = false;
+    $config->standards = [self::STANDARD_NAME];
+    $config->ignored   = [];
+
+    $sniffFiles = [realpath(self::SNIFF_FILE)];
+    $ruleset    = new Ruleset($config);
     $ruleset->registerSniffs($sniffFiles, [], []);
     $ruleset->populateTokenListeners();
     if (! file_exists($fixtureFile)) {
@@ -35,10 +40,6 @@ public function getErrorLineNumbersFromFile(LocalFile $phpcsFile) {
     return $this->getLineNumbersFromMessages($phpcsFile->getErrors());
   }
 
-  public function getSniffFiles() {
-    return [realpath(__DIR__ . '/../../VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php')];
-  }
-
   public function getFixture($fixtureFilename) {
     return realpath(__DIR__ . '/CodeAnalysis/fixtures/' . $fixtureFilename);
   }