QA: minor code tweak (#282)

jrfnl · web-flow · commit 81f5f19ceaa5 · 2022-10-15T19:24:19.000-04:00
This fixes the following error from PHPStan:
```
 ------ ---------------------------------------------------------
  Line   Lib/Helpers.php
 ------ ---------------------------------------------------------
  758    Cannot access offset int on 0|0.0|''|'0'|array{}|false.
 ------ ---------------------------------------------------------
```

Co-authored-by: jrfnl &lt;jrfnl@users.noreply.github.com&gt;
diff --git a/VariableAnalysis/Lib/Helpers.php b/VariableAnalysis/Lib/Helpers.php
@@ -755,7 +755,7 @@ public static function getListAssignments(File $phpcsFile, $listOpenerIndex)
 				$parentSquareBracket = self::findContainingOpeningSquareBracket($phpcsFile, $listOpenerIndex);
 				if (is_int($parentSquareBracket)) {
 					// Collect the opening index, but we don't actually need the closing paren index so just make that 0
-					$parents[$parentSquareBracket] = 0;
+					$parents = [$parentSquareBracket => 0];
 				}
 			}
 			// If we have no parents, this is not a nested assignment and therefore is not an assignment

Original file line number	Diff line number	Diff line change
`@@ -755,7 +755,7 @@ public static function getListAssignments(File $phpcsFile, $listOpenerIndex)`
`755`	`755`	`$parentSquareBracket = self::findContainingOpeningSquareBracket($phpcsFile, $listOpenerIndex);`
`756`	`756`	`if (is_int($parentSquareBracket)) {`
`757`	`757`	`// Collect the opening index, but we don't actually need the closing paren index so just make that 0`
`758`		`- $parents[$parentSquareBracket] = 0;`
	`758`	`+ $parents = [$parentSquareBracket => 0];`
`759`	`759`	`}`
`760`	`760`	`}`
`761`	`761`	`// If we have no parents, this is not a nested assignment and therefore is not an assignment`