Handle superglobals within double-quoted strings correctly.

Author: illusori

Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -1241,6 +1241,9 @@ protected function processVariableInString(
             if ($this->checkForThisWithinClass($phpcsFile, $stackPtr, $varName, $currScope)) {
                 continue;
             }
+            if ($this->checkForSuperGlobal($phpcsFile, $stackPtr, $varName, $currScope)) {
+                return;
+            }
             $this->markVariableRead($varName, $stackPtr, $currScope);
             if ($this->isVariableUndefined($varName, $stackPtr, $currScope) === true) {
                 $phpcsFile->addWarning("Variable %s is undefined.", $stackPtr,

Tests/CodeAnalysis/VariableAnalysisUnitTest.inc

@@ -374,4 +374,5 @@ function function_with_superglobals() {
     echo print_r($_SESSION, true);
     echo print_r($_REQUEST, true);
     echo print_r($_ENV, true);
+    echo "$GLOBALS['whatever']";
 }