VariableAnalysisSniff::checkForStaticMember(): fix comment tolerance [1] (#147)

PHP ignores comments in unexpected/unconventional places and so should the sniff.

Includes adjusting an existing unit test.

Without the fix, the adjusted unit test would cause test failures.

Author: jrfnl

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -668,19 +668,19 @@ protected function checkForSuperGlobal(File $phpcsFile, $stackPtr, $varName) {
   protected function checkForStaticMember(File $phpcsFile, $stackPtr, $varName, $currScope) {
     $tokens = $phpcsFile->getTokens();
 
-    $doubleColonPtr = $stackPtr - 1;
-    if ($tokens[$doubleColonPtr]['code'] !== T_DOUBLE_COLON) {
+    $doubleColonPtr = $phpcsFile->findPrevious(Tokens::$emptyTokens, $stackPtr - 1, null, true);
+    if ($doubleColonPtr === false || $tokens[$doubleColonPtr]['code'] !== T_DOUBLE_COLON) {
       return false;
     }
-    $classNamePtr = $stackPtr - 2;
+    $classNamePtr = $phpcsFile->findPrevious(Tokens::$emptyTokens, $doubleColonPtr - 1, null, true);
     $staticReferences = [
       T_STRING,
       T_SELF,
       T_PARENT,
       T_STATIC,
       T_VARIABLE,
     ];
-    if (! in_array($tokens[$classNamePtr]['code'], $staticReferences, true)) {
+    if ($classNamePtr === false || ! in_array($tokens[$classNamePtr]['code'], $staticReferences, true)) {
       return false;
     }
     // "When calling static methods, the function call is stronger than the

VariableAnalysis/Tests/CodeAnalysis/fixtures/ClassWithMembersFixture.php

@@ -52,7 +52,7 @@ class ClassWithMembers {
     function method_with_member_var() {
         echo $this->member_var;
         echo $this->no_such_member_var;
-        echo self::$static_member_var;
+        echo self :: $static_member_var;
         echo self::$no_such_static_member_var;
         echo SomeOtherClass::$external_static_member_var;
     }
@@ -73,7 +73,7 @@ static function method_with_late_static_binding($param) {
 class ChildClassWithMembers extends ClassWithMembers {
     function method_with_parent_reference() {
         echo self::$static_member_var;
-        echo parent::$no_such_static_member_var;
+        echo parent /*comment*/ :: $no_such_static_member_var;
     }
 }
 
@@ -87,7 +87,7 @@ function method_with_member_var() {
         echo $this->member_var;
         echo $this->no_such_member_var;
         echo self::$static_member_var;
-        echo self::$no_such_static_member_var;
+        echo self::  /*comment*/  $no_such_static_member_var;
         echo SomeOtherClass::$external_static_member_var;
     }