ANDROID: complain when samsum keyboard detected

Author: chrisws

ChangeLog

@@ -1,3 +1,7 @@
+2020-05-11 (0.12.19)
+	ANDROID: complain when samsung keyboard detected
+	COMMON: fix compile warnings
+
 2020-05-11 (0.12.19)
 	FLTK: Fix compile warnings with updated gcc
 

src/common/brun.c

@@ -352,7 +352,7 @@ void cmd_chain(void) {
   if (var.type == V_STR) {
     if (access(var.v.p.ptr, R_OK) == 0) {
       // argument is a file name
-      int h = open(var.v.p.ptr, O_BINARY | O_RDONLY, 0644);
+      int h = open(var.v.p.ptr, O_BINARY | O_RDONLY);
       if (h != -1) {
         struct stat st;
         if (fstat(h, &st) == 0) {
@@ -1144,7 +1144,7 @@ int brun_create_task(const char *filename, byte *preloaded_bc, int libf) {
       return search_task(fname);
     }
     // open & load
-    int h = open(fname, O_RDWR | O_BINARY, 0660);
+    int h = open(fname, O_RDWR | O_BINARY);
     if (h == -1) {
       panic("File '%s' not found", fname);
     }

src/common/units.c

@@ -147,7 +147,7 @@ int open_unit(const char *file) {
   }
 
   // open unit
-  h = open(unitname, O_RDWR | O_BINARY, 0660);
+  h = open(unitname, O_RDWR | O_BINARY);
   if (h == -1) {
     return -1;
   }

src/platform/android/app/build.gradle

@@ -2,13 +2,13 @@ apply plugin: 'com.android.application'
 
 android {
   // app can use the API features included in this API level and lower.
-  compileSdkVersion 28
+  compileSdkVersion 29
 
   // can override some attributes in main/AndroidManifest.xml
   defaultConfig {
     applicationId 'net.sourceforge.smallbasic'
     minSdkVersion 16
-    targetSdkVersion 28
+    targetSdkVersion 29
     versionCode 39
     versionName "0.12.17"
     resConfigs "en"

src/platform/android/app/src/main/java/net/sourceforge/smallbasic/MainActivity.java

@@ -24,6 +24,7 @@
 import android.os.Bundle;
 import android.os.Environment;
 import android.os.Handler;
+import android.provider.Settings;
 import android.util.Base64;
 import android.util.DisplayMetrics;
 import android.util.Log;
@@ -82,7 +83,7 @@
 /**
  * Extends NativeActivity to provide interface methods for runtime.cpp
  *
- * @author chrisws
+ * @author Chris Warren-Smith
  */
 public class MainActivity extends NativeActivity {
   private static final String TAG = "smallbasic";
@@ -586,11 +587,17 @@ public void onClick(DialogInterface dialog, int which) {}
   public void showKeypad(final boolean show) {
     Log.i(TAG, "showKeypad: " + show);
     final View view = getWindow().getDecorView();
+    final Activity activity = this;
     runOnUiThread(new Runnable() {
       public void run() {
         InputMethodManager imm = (InputMethodManager)getSystemService(Context.INPUT_METHOD_SERVICE);
         if (imm != null) {
           if (show) {
+            String id = Settings.Secure.getString(activity.getContentResolver(), Settings.Secure.DEFAULT_INPUT_METHOD);
+            if ("com.sec.android.inputmethod/.SamsungKeypad".equals(id)) {
+              String message = getResources().getString(R.string.samsung_keyboard);
+              Toast.makeText(activity, message, Toast.LENGTH_LONG).show();
+            }
             imm.showSoftInput(view, InputMethodManager.SHOW_IMPLICIT);
           } else {
             imm.hideSoftInputFromWindow(view.getWindowToken(), InputMethodManager.HIDE_NOT_ALWAYS);

src/platform/android/app/src/main/java/net/sourceforge/smallbasic/TextToSpeechAdapter.java

@@ -1,12 +1,12 @@
 package net.sourceforge.smallbasic;
 
-import java.util.Locale;
-
 import android.content.Context;
 import android.speech.tts.TextToSpeech;
 import android.speech.tts.TextToSpeech.OnInitListener;
 import android.util.Log;
 
+import java.util.Locale;
+
 class TextToSpeechAdapter implements OnInitListener {
   private static final String TAG = "smallbasic";
   private final TextToSpeech _tts;

src/platform/android/app/src/main/res/values/strings.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
   <string name="app_name">SmallBASIC</string>
+  <string name="samsung_keyboard">Samsung keyboard not supported. Please use an alternative keyboard.</string>
   <style name="SBTheme" parent="android:Theme.Holo.Light">
     <item name="android:windowActionBar">false</item>
     <item name="android:windowNoTitle">true</item>

src/ui/system.cpp

@@ -594,7 +594,7 @@ char *System::readSource(const char *fileName) {
   } else {
     buffer = loadResource(fileName);
     if (!buffer) {
-      int h = open(fileName, O_BINARY | O_RDONLY, 0644);
+      int h = open(fileName, O_BINARY | O_RDONLY);
       if (h != -1) {
         struct stat st;
         if (fstat(h, &st) == 0) {