Skip to content

Commit 3d7128c

Browse files
authored
fix: syntax fix for required_fields struct in rest transport (googleapis#1103)
1 parent 6d78f5e commit 3d7128c

File tree

8 files changed

+6
-13
lines changed

8 files changed

+6
-13
lines changed

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class {{service.name}}RestTransport({{service.name}}Transport):
170170
{% if method.input.required_fields %}
171171
__{{ method.name | snake_case }}_required_fields_default_values = {
172172
{% for req_field in method.input.required_fields if req_field.is_primitive %}
173-
"{{ req_field.name | camel_case }}" : {% if req_field.field_pb.default_value is string %}"{{req_field.field_pb.default_value }}"{% else %}{{ req_field.field_pb.default_value }}{% endif %}{# default is str #}
173+
"{{ req_field.name | camel_case }}" : {% if req_field.field_pb.default_value is string %}"{{req_field.field_pb.default_value }}"{% else %}{{ req_field.field_pb.default_value }}{% endif %},{# default is str #}
174174
{% endfor %}
175175
}
176176

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ import mock
77

88
import grpc
99
from grpc.experimental import aio
10+
{% if "rest" in opts.transport %}
1011
import json
12+
{% endif %}
1113
import math
1214
import pytest
1315
from proto.marshal.rules.dates import DurationRule, TimestampRule
@@ -37,11 +39,12 @@ from google.api_core import grpc_helpers_async
3739
from google.api_core import path_template
3840
{% if service.has_lro %}
3941
from google.api_core import future
40-
from google.api_core import operation
4142
from google.api_core import operations_v1
4243
from google.longrunning import operations_pb2
44+
{% if "rest" in opts.transport %}
4345
from google.protobuf import json_format
44-
{% endif %}
46+
{% endif %}{# rest transport #}
47+
{% endif %}{# lro #}
4548
from google.api_core import gapic_v1
4649
{% for method in service.methods.values() %}
4750
{% for ref_type in method.ref_types

tests/integration/goldens/asset/tests/unit/gapic/asset_v1/test_asset_service.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import grpc
2020
from grpc.experimental import aio
21-
import json
2221
import math
2322
import pytest
2423
from proto.marshal.rules.dates import DurationRule, TimestampRule
@@ -30,7 +29,6 @@
3029
from google.api_core import gapic_v1
3130
from google.api_core import grpc_helpers
3231
from google.api_core import grpc_helpers_async
33-
from google.api_core import operation
3432
from google.api_core import operation_async # type: ignore
3533
from google.api_core import operations_v1
3634
from google.api_core import path_template
@@ -46,7 +44,6 @@
4644
from google.oauth2 import service_account
4745
from google.protobuf import duration_pb2 # type: ignore
4846
from google.protobuf import field_mask_pb2 # type: ignore
49-
from google.protobuf import json_format
5047
from google.protobuf import timestamp_pb2 # type: ignore
5148
from google.type import expr_pb2 # type: ignore
5249
import google.auth

tests/integration/goldens/credentials/tests/unit/gapic/credentials_v1/test_iam_credentials.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import grpc
2020
from grpc.experimental import aio
21-
import json
2221
import math
2322
import pytest
2423
from proto.marshal.rules.dates import DurationRule, TimestampRule

tests/integration/goldens/logging/tests/unit/gapic/logging_v2/test_config_service_v2.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import grpc
2020
from grpc.experimental import aio
21-
import json
2221
import math
2322
import pytest
2423
from proto.marshal.rules.dates import DurationRule, TimestampRule

tests/integration/goldens/logging/tests/unit/gapic/logging_v2/test_logging_service_v2.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import grpc
2020
from grpc.experimental import aio
21-
import json
2221
import math
2322
import pytest
2423
from proto.marshal.rules.dates import DurationRule, TimestampRule

tests/integration/goldens/logging/tests/unit/gapic/logging_v2/test_metrics_service_v2.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import grpc
2020
from grpc.experimental import aio
21-
import json
2221
import math
2322
import pytest
2423
from proto.marshal.rules.dates import DurationRule, TimestampRule

tests/integration/goldens/redis/tests/unit/gapic/redis_v1/test_cloud_redis.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import grpc
2020
from grpc.experimental import aio
21-
import json
2221
import math
2322
import pytest
2423
from proto.marshal.rules.dates import DurationRule, TimestampRule
@@ -30,7 +29,6 @@
3029
from google.api_core import gapic_v1
3130
from google.api_core import grpc_helpers
3231
from google.api_core import grpc_helpers_async
33-
from google.api_core import operation
3432
from google.api_core import operation_async # type: ignore
3533
from google.api_core import operations_v1
3634
from google.api_core import path_template
@@ -44,7 +42,6 @@
4442
from google.longrunning import operations_pb2
4543
from google.oauth2 import service_account
4644
from google.protobuf import field_mask_pb2 # type: ignore
47-
from google.protobuf import json_format
4845
from google.protobuf import timestamp_pb2 # type: ignore
4946
import google.auth
5047

0 commit comments

Comments
 (0)