chore(svelte): Simplify development for dotcom (#63341)

fkling · web-flow · commit 15ea951e0d72 · 2024-06-19T22:55:01.000+02:00
Whether or not the app is in "dotcom mode" is determined by `window.context.sourcegraphDotComMode`. In development we use a stub `window.context` object defined in `app.html`. This commit extends that object to set `sourcegraphDotComMode` depending on an environment varible. The environment variable is set by using vite modes (https://vitejs.dev/guide/env-and-mode.html). The whole setup can be started with `pnpm dev:dotcom`. ## Test plan Ran `pnpm dev:dotcom` and saw the dotcom specific header and footer.
diff --git a/client/web-sveltekit/.env.dotcom b/client/web-sveltekit/.env.dotcom
@@ -1,2 +1 @@
-PUBLIC_SG_ENTERPRISE=true
 PUBLIC_DOTCOM=true
diff --git a/client/web-sveltekit/.env.oss b/client/web-sveltekit/.env.oss
diff --git a/client/web-sveltekit/package.json b/client/web-sveltekit/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.1",
   "scripts": {
     "dev": "vite dev",
-    "dev:dotcom": "vite dev --mode=dotcom",
+    "dev:dotcom": "SOURCEGRAPH_API_URL=https://sourcegraph.com vite dev --mode=dotcom",
     "dev:enterprise": "DEPLOY_TYPE=dev vite build --watch",
     "build": "vite build",
     "build:preview": "vite build --mode=preview",
diff --git a/client/web-sveltekit/src/app.html b/client/web-sveltekit/src/app.html
@@ -1,4 +1,5 @@
 <!DOCTYPE html>
+<!-- Template used for local development only -->
 <html lang="en">
     <head>
         <meta charset="utf-8" />
@@ -16,6 +17,9 @@
                 xhrHeaders: {
                     'X-Requested-With': 'Sourcegraph',
                 },
+                // Local standalone dev server for dotcom can be started with
+                // pnpm dev:dotcom
+                sourcegraphDotComMode: '%sveltekit.env.PUBLIC_DOTCOM%' ? true : false,
             }
             window.pageError = undefined
         </script>

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`		`-PUBLIC_SG_ENTERPRISE=true`
`2`	`1`	`PUBLIC_DOTCOM=true`