This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: make repo exclusion exact #55096
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 429c6202041416d60daadc58cbadebbd578226e6...8143907321857f300e3e2855f49c972ffd7caff2.
|
Contributor
burmudar
force-pushed
the
wb/batches/eclude-repo-exact
branch
from
8143907 to
1b68de0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When excluded a repo via the UI it doesn't put an exact match in the repo query. This can result in "why is this being excluded" if you have repos that have similar prefix ie. sourcegraph.
Old behaviour
User action: exclude "sourcegraph/sourcegraph"
adds
-repo:sourcegraph/sourcegraphwhich would not only matchsourcegraph/sourcegraphbut alsosourcegraph/sourcegraph-k8setc.New behaviour
User action: exclude "sourcegraph/sourcegraph"
adds
-repo:^sourcegraph/sourcegraph$which only matchessourcegraph/sourcegraphand notsourcegraph/sourcegraph-k8setc.Test plan
Tested manually