Skip to content

Commit a8f0fc7

Browse files
lewispg228lewispg228
committed
sound effects const arguments passed by reference
1 parent 008fb4d commit a8f0fc7

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

‎src/sfeQwiicBuzzer.cpp‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ uint8_t sfeQwiicBuzzerArdI2C::getAddress()
130130

131131
/*------------------------- Sound Effects ---------------- */
132132

133-
sfeTkError_t sfeQwiicBuzzerArdI2C::playSoundEffect(uint8_t soundEffectNumber, uint8_t volume)
133+
sfeTkError_t sfeQwiicBuzzerArdI2C::playSoundEffect(const uint8_t &soundEffectNumber, const uint8_t &volume)
134134
{
135135
sfeTkError_t err;
136136

@@ -171,7 +171,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::playSoundEffect(uint8_t soundEffectNumber, ui
171171
}
172172

173173
// SIREN SLOW X1
174-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect0(uint8_t volume)
174+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect0(const uint8_t &volume)
175175
{
176176
sfeTkError_t err;
177177
for (int note = 150 ; note < 4000 ; note += 150)
@@ -198,7 +198,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect0(uint8_t volume)
198198
}
199199

200200
// SIREN FAST X3
201-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect1(uint8_t volume)
201+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect1(const uint8_t &volume)
202202
{
203203
sfeTkError_t err;
204204
for (int i = 0 ; i <= 2 ; i++)
@@ -224,7 +224,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect1(uint8_t volume)
224224
}
225225

226226
// YES SLOW
227-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect2(uint8_t volume)
227+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect2(const uint8_t &volume)
228228
{
229229
sfeTkError_t err;
230230
for (int note = 150 ; note < 4000 ; note += 150)
@@ -239,7 +239,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect2(uint8_t volume)
239239
}
240240

241241
// YES FAST
242-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect3(uint8_t volume)
242+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect3(const uint8_t &volume)
243243
{
244244
sfeTkError_t err;
245245
for (int note = 150 ; note < 4000 ; note += 150)
@@ -254,7 +254,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect3(uint8_t volume)
254254
}
255255

256256
// NO SLOW
257-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect4(uint8_t volume)
257+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect4(const uint8_t &volume)
258258
{
259259
sfeTkError_t err;
260260
for (int note = 4000 ; note > 150 ; note -= 150)
@@ -269,7 +269,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect4(uint8_t volume)
269269
}
270270

271271
// NO FAST
272-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect5(uint8_t volume)
272+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect5(const uint8_t &volume)
273273
{
274274
sfeTkError_t err;
275275
for (int note = 4000 ; note > 150 ; note -= 150)
@@ -284,7 +284,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect5(uint8_t volume)
284284
}
285285

286286
// LAUGH
287-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect6(uint8_t volume)
287+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect6(const uint8_t &volume)
288288
{
289289
sfeTkError_t err;
290290
int laughdelay = 400;
@@ -346,7 +346,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect6(uint8_t volume)
346346
}
347347

348348
// LAUGH FAST
349-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect7(uint8_t volume)
349+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect7(const uint8_t &volume)
350350
{
351351
sfeTkError_t err;
352352
int laughdelay = 200;
@@ -407,7 +407,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect7(uint8_t volume)
407407
}
408408

409409
// CRY SLOW
410-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect8(uint8_t volume)
410+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect8(const uint8_t &volume)
411411
{
412412
sfeTkError_t err;
413413
int crydelay = 500;
@@ -454,7 +454,7 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect8(uint8_t volume)
454454
}
455455

456456
// CRY FAST
457-
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect9(uint8_t volume)
457+
sfeTkError_t sfeQwiicBuzzerArdI2C::soundEffect9(const uint8_t &volume)
458458
{
459459
sfeTkError_t err;
460460
int crydelay = 200;

‎src/sfeQwiicBuzzer.h‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -93,57 +93,57 @@ class sfeQwiicBuzzerArdI2C
9393
/// @param soundEffectNumber The sound effect you with to play
9494
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
9595
/// @return 0 for succuss, negative for errors, positive for warnings
96-
sfeTkError_t playSoundEffect(uint8_t soundEffectNumber, uint8_t volume);
96+
sfeTkError_t playSoundEffect(const uint8_t &soundEffectNumber, const uint8_t &volume);
9797

9898
/// @brief Plays sound effect 0
9999
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
100100
/// @return 0 for succuss, negative for errors, positive for warnings
101-
sfeTkError_t soundEffect0(uint8_t volume);
101+
sfeTkError_t soundEffect0(const uint8_t &volume);
102102

103103
/// @brief Plays sound effect 1
104104
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
105105
/// @return 0 for succuss, negative for errors, positive for warnings
106-
sfeTkError_t soundEffect1(uint8_t volume);
106+
sfeTkError_t soundEffect1(const uint8_t &volume);
107107

108108
/// @brief Plays sound effect 2
109109
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
110110
/// @return 0 for succuss, negative for errors, positive for warnings
111-
sfeTkError_t soundEffect2(uint8_t volume);
111+
sfeTkError_t soundEffect2(const uint8_t &volume);
112112

113113
/// @brief Plays sound effect 3
114114
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
115115
/// @return 0 for succuss, negative for errors, positive for warnings
116-
sfeTkError_t soundEffect3(uint8_t volume);
116+
sfeTkError_t soundEffect3(const uint8_t &volume);
117117

118118
/// @brief Plays sound effect 4
119119
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
120120
/// @return 0 for succuss, negative for errors, positive for warnings
121-
sfeTkError_t soundEffect4(uint8_t volume);
121+
sfeTkError_t soundEffect4(const uint8_t &volume);
122122

123123
/// @brief Plays sound effect 5
124124
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
125125
/// @return 0 for succuss, negative for errors, positive for warnings
126-
sfeTkError_t soundEffect5(uint8_t volume);
126+
sfeTkError_t soundEffect5(const uint8_t &volume);
127127

128128
/// @brief Plays sound effect 6
129129
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
130130
/// @return 0 for succuss, negative for errors, positive for warnings
131-
sfeTkError_t soundEffect6(uint8_t volume);
131+
sfeTkError_t soundEffect6(const uint8_t &volume);
132132

133133
/// @brief Plays sound effect 7
134134
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
135135
/// @return 0 for succuss, negative for errors, positive for warnings
136-
sfeTkError_t soundEffect7(uint8_t volume);
136+
sfeTkError_t soundEffect7(const uint8_t &volume);
137137

138138
/// @brief Plays sound effect 8
139139
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
140140
/// @return 0 for succuss, negative for errors, positive for warnings
141-
sfeTkError_t soundEffect8(uint8_t volume);
141+
sfeTkError_t soundEffect8(const uint8_t &volume);
142142

143143
/// @brief Plays sound effect 9
144144
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
145145
/// @return 0 for succuss, negative for errors, positive for warnings
146-
sfeTkError_t soundEffect9(uint8_t volume);
146+
sfeTkError_t soundEffect9(const uint8_t &volume);
147147

148148
protected:
149149
sfeTkII2C *_theBus;

0 commit comments

Comments
 (0)